Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies/plugins - Eleventy v1.0.1 and eleventy-fetch v3.0.0 #2

Closed
wants to merge 10 commits into from

Conversation

ItsMeAra
Copy link
Contributor

Thank you for this great plugin!

I was trying it out and noticed it was using a canary version of 11ty and the old eleventy-cache-assets plugin, so thought I'd update both to the newer versions.

  • Update Eleventy to latest version (v1.0.1)
  • Replace eleventy-cache-assets plugin with the newer eleventy-fetch plugin
  • Update Eleventy build/dev commands to use npx @11ty/eleventy as recommended by docs
  • Update Readme file to reflect changes

Remove @11ty/eleventy-cache-assets and replace with newer @11ty/eleventy-fetch v3.0.0
Upgrade 11ty package from 1.0.0-canary.41 to 1.0.1
Update readme note about Eleventy version required
Update readme to reflect using eleventy-fetch instead of eleventy-cache-assets
@netlify
Copy link

netlify bot commented May 12, 2022

‼️ Deploy request for eleventy-plugin-ghost rejected.

Name Link
🔨 Latest commit 51b2348

@daviddarnes
Copy link
Owner

Hey @ItsMeAra this is awesome! Thanks for contributing. I allowed a Netlify preview to build and it's all looking good. Just a couple of questions, will npx source the right eleventy when it's ran? Also, can the commit noise be reduced at all? No worries if not

@daviddarnes daviddarnes self-assigned this May 12, 2022
@ItsMeAra
Copy link
Contributor Author

@daviddarnes Sweet!

will npx source the right eleventy when it's ran?
Yup! Using npx @11ty/eleventy uses the local project version of Eleventy. Just using eleventy only works if you have eleventy installed as a global package. If you don't have it globally installed and run it, it will execute the wrong package.

can the commit noise be reduced at all?
My bad haha, sure let me look into it and give it a shot.

@ItsMeAra
Copy link
Contributor Author

Ok I tried to squash some commits together but feel like something funky might have happened 🤦🏻‍♂️ I can just redo all this in a cleaner way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants