With recent changes in systems part of our cli, we introduced issues with for "system register" command. Both variants with environment provided or with multiple activation keys (separated with comma) did not work. This patch fixes both cli and backend API.
When running some tasks the logger might not be available when loading configuration.
Code loaded with require is not reloaded in development mode after each request and therefore it's needed to restart the whole server. Using require_dependency instead might lead to memory leaks when some constants are not marked for reload. Since we have `lib` dir already in autoload paths we can let Rails to load and unload the code automatically when following convetions. Therefore modules under `lib/resources` dir were moved to `Resources` module so that Rails knows where to find them. This change should also improve the code readability: e.g. it's clearer where the Candlepin module is defined now.
New generator is called from the spec %build section. I had to move our setup_admin out of bin/katello to src/katello/client/main.py library file. It will possibly make some conflicts, but eventually its a good idea to have such a library function out of main executable.
We are currently relying on katello-configure's puppet manifests to install qpid and mongodb RPMS. See modules/qpid/manifests/install.pp and modules/qpid/manifests/install.pp. We ideally will just add these to the katello-common set of Requires and not be forced to have katello-configure catch this missing dependency. Without this it makes it harder to pre-build systems with the right RPM set and is misleading that you could remove qpid-cpp-server-ssl and nothing would complain. So I am adding those to katello-all package rather than katello-common, because those are dependencies of backend engines which are also installed in the "all" section. After this patch, we should not see any packages to be installed using Puppet: $ grep "yum.*install" /var/log/katello/katello-configure/main.log