Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install instruction added #120

Merged
merged 2 commits into from May 30, 2018
Merged

pip install instruction added #120

merged 2 commits into from May 30, 2018

Conversation

SushilShrestha
Copy link
Contributor

Added pip installation script to the Readme file.

@coveralls
Copy link

coveralls commented May 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling d2aeaf9 on SushilShrestha:SushilShrestha-patch-1 into 8f535a7 on daviddrysdale:dev.

README.md Outdated
@@ -12,6 +12,13 @@ Original Java code is Copyright (C) 2009-2015 The Libphonenumber Authors.
Release [HISTORY](python/HISTORY.md), derived from [upstream release notes](https://github.com/googlei18n/libphonenumber/blob/master/release_notes.txt).


Installation
-------------
Install using [pip](https://pypi.org/) with:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the link destination more pip-specific? Maybe [pip](https://pypi.org/project/pip/) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@daviddrysdale daviddrysdale merged commit 163d42c into daviddrysdale:dev May 30, 2018
@daviddrysdale
Copy link
Owner

Thanks!

Themimitoof pushed a commit to Themimitoof/python-phonenumbers that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants