Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user interface for the TEX parser tool #1

Closed
wants to merge 13 commits into from

Conversation

Projects
None yet
3 participants
@davidemdot
Copy link
Owner

commented Jun 12, 2019

The goal has been to connect the back-end of the parser with the user interface:

A first dialog box will ask for a directory for scanning TEX files. For displaying these entries, a new dialog box will be opened.

User Interface

Any feedback is more than welcome!

@tobiasdiez
Copy link

left a comment

This looks already pretty good. I've a few remark, which mostly concern the mvvm pattern. Feel free to ask here or in gitter if you have any questions or if you need further clarifications.

Fix some issues discussed in the PR
Use of @Inject
Remove JabRefFrame parameter
Change TreeView for CheckTreeView
Use ViewModelTreeCellFactory
Move ReferenceWrapper to a separated class
Adapt ParseTexResult to MVVM architecture
Use LatexToUnicodeAdapter and change CSS for ResultView
@davidemdot

This comment has been minimized.

Copy link
Owner Author

commented Jun 20, 2019

@Siedlerchr and @tobiasdiez, thanks for your feedback!

Please check if the MVVM architecture is used in a proper way in ParseTexResultView and ParseTexResultViewModel.

After last style changes, it looks...

New GUI

:"D


Changes:

  • Adapt ParseTexResult to MVVM architecture
  • Change TreeView for CheckTreeView
  • Use ViewModelTreeCellFactory
  • Use LatexToUnicodeAdapter and change CSS for result view
  • Move ReferenceWrapper to a separated class
  • Use of @Inject
  • Remove JabRefFrame parameter

Todo:

  • Adapt ParseTexDialog to MVVM architecture
  • Use Path instead of File in TexFileCrawler
  • Implement jumpToFile() in ParseTexResultViewModel
@tobiasdiez
Copy link

left a comment

This looks so much better than the previous version (which was already quite ok). Good job!

I still have a few suggestions. Is the dialog feature complete from your point (maybe except the jump to file feature), or do you want to add a few more things?

@davidemdot davidemdot force-pushed the latex-integration-project branch from 2037295 to 568d0a5 Jun 27, 2019

@davidemdot davidemdot added the GSoC label Jun 27, 2019

@davidemdot davidemdot force-pushed the latex-integration-project branch from 2ada331 to 2037295 Jun 28, 2019

@davidemdot davidemdot force-pushed the gsoc-latex-gui branch from 47479e0 to 08eac13 Jun 28, 2019

@davidemdot

This comment has been minimized.

Copy link
Owner Author

commented Jul 1, 2019

@tobiasdiez @Siedlerchr

Hi guys! I think that the logic is already separated of the view.

As you can see, I have recovered a previous version of the WalkFileTreeTask class, because I have been getting some errors. No worries about this, I will review it along this week.

@davidemdot

This comment has been minimized.

Copy link
Owner Author

commented Jul 1, 2019

When you think is ready, I can send a new pull request with all these changes to the main repository. Thank you!

@davidemdot davidemdot closed this Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.