Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement a check for try in case libstdc++ implements c++11 where tr1 is merged into std #98

Open
GoogleCodeExporter opened this issue Apr 11, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Please implement a check for try in case libstdc++ implements c++11 where tr1 
is merged into std. For instance, clang on OSX 10.9 w/ Xcode 5.0.2 & llvm 5.0 
(500) doesn't include tr1 headers anymore, so build will fail.

Fix here is to patch the header for now:

#define HASH_FUN_H <tr1/functional> => #define HASH_FUN_H <functional>
#define HASH_NAMESPACE std::tr1 => #define HASH_NAMESPACE std

There needs to be a check in place that could verify if either TR1 can be used 
or a newer version is in place. This can easily be done by verifying the std:

if ( __cplusplus >= 201103L ) { /*...*/ }

Thanks

Original issue reported on code.google.com by kkooporation@gmail.com on 3 Mar 2014 at 11:14

@GoogleCodeExporter
Copy link
Author

"Please implement a check for tr1"* Sorry, autocorrect.

Original comment by kkooporation@gmail.com on 3 Mar 2014 at 11:21

@GoogleCodeExporter
Copy link
Author

could you post what it looks like when it fails please?

Original comment by rogerdp...@gmail.com on 13 Mar 2014 at 3:47

@GoogleCodeExporter
Copy link
Author

Failure on OS X looks like: https://gist.github.com/adamv/10224462

Original comment by fla...@gmail.com on 9 Apr 2014 at 3:50

@GoogleCodeExporter
Copy link
Author

patch possible (as diff)?

Original comment by rogerpack2005 on 28 Apr 2014 at 11:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant