Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with special characters (e.g. umlauts) and emphasis #110

Closed
Skyr opened this issue Aug 19, 2013 · 4 comments
Closed

Problem with special characters (e.g. umlauts) and emphasis #110

Skyr opened this issue Aug 19, 2013 · 4 comments
Labels

Comments

@Skyr
Copy link

Skyr commented Aug 19, 2013

The emphasis (and probably more, I didn't test that) markup symbol is not correctly recognized if the character immediately following (or, in the closing case, the character immediately preceding) is a special character like a german umlaut (same problem with „typographic quotes“):

require 'rdiscount'
markdown = RDiscount.new("*foo ä bar*")
puts markdown.to_html   # <p><em>foo ä bar</em></p> <-- as expected
markdown = RDiscount.new("*ä foobar*")
puts markdown.to_html   # <p>*ä foobar*</p> <-- Emphasis is missing!
markdown = RDiscount.new("*foobar ä*")
puts markdown.to_html   # <p>*foobar ä*</p> <-  Emphasis is missing!

Tested with rdiscount 2.1.6.

@davidfstr
Copy link
Owner

Interesting. I will run a test with the underlying Discount.

@davidfstr
Copy link
Owner

Confirmed in Discount 2.1.6. Filed upstream as: Orc/discount#85

@Skyr
Copy link
Author

Skyr commented Aug 20, 2013

Thanks for testing and forwarding the bug!

@davidfstr
Copy link
Owner

This is fixed in RDiscount 2.1.7.

I will add a regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants