Ross Combs' big patch

[DavidGriffith]

This is a large patch presented to Greg by Ross Combs in xv-20120505-ross-combs-middle-button-paste.mime and xv-20120507-ross-combs-middle-button-paste.mime. The second patch is an update of the first patch.

From the first patch:

I don't remember which state of the patch you have, and I just did some testing after fixing the paste portion so I rediffed it.

The major parts are:

• resize support
• middle-click pasting
• option to make window geometries pretend to be user-specified

From the second patch:

I couldn't stand it. I broke down an implemented all the common select/paste editing operations and added notes to the keyboard help window. New patch attached.

I've tested it out manually but you should probably too since I may be blind to my own bugs after messing with it so long.

I took the liberty of adding a few things I found annoying to the wishlist:

• tooltips for buttons with icons
• fix meta/alt/mod1 confusion in event handling and docs
• fix strange non-ICCCM positioning which causes windows to drift
  when operations are performed and other strangeness

I guess I could also add having two-mode selection support (so you can see if the highlighted text is no longer the active PRIMARY item) -- I didn't want to mess with colors because of B&W support.

By the way, it looks like there are a lot of signed arithmetic operation overflows which GCC is warning about with -Wall. Many appear to be in buffer length checks and other security-related code.

[DavidGriffith]

In the first pair of files, a file xvselect.c was missing. I found it later in the second pair of files (see below) MIME-encoded.

Files involved are:
xv-20071013-ross-combs-resize-ppos-paste.msg
xv-20071013-ross-combs-resize-ppos-paste.patch
xv-20120505-ross-combs-middle-button-paste.mime
xv-20120507-ross-combs-middle-button-paste.mime

[DavidGriffith]

I'm not sure if the window drift Ross is talking about is applies to newer window managers. Certainly it applies to older window managers like twm, mwm, and fvwm.

[DavidGriffith]

Applied in c59166e