completions: skip docstr without preview, handle exceptions #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
blueyed
force-pushed
the
completions-opt
branch
from
f92733c
to
a28da90
Compare
davidhalter
reviewed
Oct 20, 2019
| d["info"] = PythonToVimStr(c.docstring()) | ||
| except Exception: | ||
| print("jedi-vim: error with docstring for %r: %s" % ( | ||
| c, traceback.format_exc())) |
There was a problem hiding this comment.
Just wondering: Do we need that? Or is this already covered by the generic error handling and you just want to know a bit more about the error (essentially the added c information)?
Otherwise I think this is a good change. Not sure though how many people aren't using preview. How about you?
There was a problem hiding this comment.
I am not using preview, but it is enabled by default IIRC.
I've thought it is good to log/print errors (otherwise we might have never noticed that it fails with parts of numpy in the first place likely). It will only show up with :mess though.
The decorator would only print it when not swallowed (what is done here now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #948.