Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.0 includes test code causing errors #257

Closed
MikeRyanDev opened this issue Sep 23, 2015 · 10 comments
Closed

v3.3.0 includes test code causing errors #257

MikeRyanDev opened this issue Sep 23, 2015 · 10 comments

Comments

@MikeRyanDev
Copy link

Looks like some test code was mistakenly published in 3.3.0: https://github.com/davidjbradshaw/iframe-resizer/blob/master/src/iframeResizer.contentWindow.js#L1038

Bundling iframeResizer from the version published on NPM throws this error: define is not defined

@MikeRyanDev MikeRyanDev changed the title Bundles test code causing issues v3.3.0 includes test code causing errors Sep 23, 2015
@davidjbradshaw
Copy link
Owner

Are you using the version in src or js?

@MikeRyanDev
Copy link
Author

Working in a node environment, so hitting index.js which does seem to be pulling in from src.

@davidjbradshaw
Copy link
Owner

Arh, give me a moment to move it to js.

@davidjbradshaw
Copy link
Owner

Can you try the dev branch build and let me know if that works for you.

@MikeRyanDev
Copy link
Author

Yeah, the dev branch works well.

@davidjbradshaw
Copy link
Owner

Thanks, released as v3.3.1.

@MikeRyanDev
Copy link
Author

Thanks for the quick response and fix!

@mbrevda
Copy link

mbrevda commented Nov 24, 2015

Is it possible that offending code is still in the source? I'm getting define is not defined error in iframeResizer.contentWindow (using npm)

@davidjbradshaw
Copy link
Owner

Use the version in the JS, not the SRC folder.

@mbrevda
Copy link

mbrevda commented Nov 24, 2015

Brilliant, thanks m8! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants