Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for iframe.src when parsing it for remoteHost #761

Merged
merged 1 commit into from Oct 8, 2019

Conversation

SuNaden
Copy link
Contributor

@SuNaden SuNaden commented Oct 4, 2019

It seems that some blockers and extensions like to maniuplate/delete the src attribute from iframes. Also it might be that you create an iframe without an src (e.g. using srcDoc).

I was experiencing an annoying bug #721, this fixed it for me.

@JanMatas
Copy link

JanMatas commented Oct 8, 2019

Is there any progress on this?

@davidjbradshaw davidjbradshaw merged commit b6dc809 into davidjbradshaw:master Oct 8, 2019
@davidjbradshaw
Copy link
Owner

Thanks for this. Released as v4.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants