-
Notifications
You must be signed in to change notification settings - Fork 1
build(e2e): generate sample apps dynamically #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow base app dir & no cleanup app generation opts
Owner
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
This was referenced Apr 12, 2024
|
🎉 This PR is included in version 1.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Issue or need
Having sample apps in the repository has some disadvantages:
Though to be fair, it has some:
Proposed changes
In order to improve disadvantages, introducing a script here to generate E2E sample apps. Which solves all disadvantages at expense of some extra complexity.
Determinism of generated apps will be improved in next PRs by pinning to a specific Angular CLI to generate those apps.
Docs have been updated to point to template files instead of now non-tracked & dynamically generated sample Angular apps.
Angular CLI schematics haven't been directly used for this purpose, but have definitely investigated (indeed parsing
tsconfigcode is extracted from Angular'scompiler-clipkg used by Angular's CLI). Main reason is that coupling to Angular CLI's CLI interface is a higher abstraction than schematics. So it's less possible it will change and will require maintenance. Also, don't have experience with schematics. So it would have taken a bit more time to create.Quick reminders