Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify virtualenv's version in setup.py #37

Closed
piotr-dobrogost opened this issue Jul 28, 2013 · 3 comments
Closed

Do not specify virtualenv's version in setup.py #37

piotr-dobrogost opened this issue Jul 28, 2013 · 3 comments

Comments

@piotr-dobrogost
Copy link
Collaborator

Virtualenvwrapper does not do this (https://bitbucket.org/dhellmann/virtualenvwrapper/src/a933b98cded25b7bebbf894d494174cd3984f113/requirements.txt?at=4.1.1) and neither should we.

The reasoning being:
a) subsequent versions of virtualenv are backwards compatible so there's no need for pinning it
b) installation of an extension should not change version of base tool

@davidmarble
Copy link
Owner

Piotr, you have shared good ideas and feedback. Thank you! Would you like to be made a contributor on this project? It would be nice to have a friend helping answer issues and requests and thinking about changes.

If yes, also send me a personal email so we can be in contact. Gmail with my username.

On Jul 28, 2013, at 5:04 AM, Piotr Dobrogost notifications@github.com wrote:

Virtualenv does not do this (https://bitbucket.org/dhellmann/virtualenvwrapper/src/a933b98cded25b7bebbf894d494174cd3984f113/requirements.txt?at=4.1.1) and neither should we.

The reasoning being:
a) subsequent versions of virtualenv are backwards compatible so there's no need for pinning it
b) installation of an extension should not change version of base tool


Reply to this email directly or view it on GitHub.

@piotr-dobrogost
Copy link
Collaborator Author

Thanks for your kind words and your offer. I see no problem in becoming a contributor. I sent an email you asked for. However I have to make two remarks. I'm thinking about switching from Windows to Linux and the more I look at Windows batch files the more I detest them. The second remark makes me want to just forget about batch files and move on to something sane like Power Shell. Hopefully there's some fun in making something which hasn't been meant to be useful to be useful in the end :)

@hobbsd
Copy link

hobbsd commented Nov 30, 2013

+1 for fixing this.

piotr-dobrogost pushed a commit that referenced this issue Dec 1, 2013
Do not pin version of virtualenv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants