Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add option to force quoting of all cells #19

Merged
merged 1 commit into from

2 participants

Barrie McGuire David Santiago
Barrie McGuire

Hi,

I've created a pull request to merge in an update. This update allows you to force that all cells be quoted. This is a requirement when working with some older versions of Excel and some database systems.

The default state for this option is false.

Let me know if you need any further explanation.

Thanks,
Barrie

David Santiago davidsantiago merged commit c504178 into from
David Santiago

Thanks for this pull request, the code was great. Just changed some formatting and added some tests, pushed it out in the 2.0.1 release. Sorry it fell under my radar for a while.

Barrie McGuire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 13, 2013
  1. Add option to force quote on all cells when writing tp CSV

    Barrie McGuire authored
This page is out of date. Refresh to see the latest.
2  project.clj
View
@@ -1,4 +1,4 @@
-(defproject clojure-csv "2.0.0-alpha2"
+(defproject clojure-csv "2.0.0-alpha3-SNAPSHOT"
:description "A simple library to read and write CSV files."
:dependencies [[org.clojure/clojure "1.3.0"]]
:plugins [[perforate "0.2.0"]]
19 src/clojure_csv/core.clj
View
@@ -240,8 +240,8 @@ and quotes. The main functions are parse-csv and write-csv."}
(defn- quote-and-escape
"Given a string (cell), returns a new string that has any necessary quoting
and escaping."
- [cell delimiter quote-char]
- (if (needs-quote? cell delimiter quote-char)
+ [cell delimiter quote-char force-quote]
+ (if (or force-quote (needs-quote? cell delimiter quote-char))
(str quote-char
(apply str (map #(escape % delimiter quote-char)
cell))
@@ -251,8 +251,8 @@ and quotes. The main functions are parse-csv and write-csv."}
(defn- quote-and-escape-row
"Given a row (vector of strings), quotes and escapes any cells where that
is necessary and then joins all the text into a string for that entire row."
- [row delimiter quote-char]
- (string/join delimiter (map #(quote-and-escape % delimiter quote-char) row)))
+ [row delimiter quote-char force-quote]
+ (string/join delimiter (map #(quote-and-escape % delimiter quote-char force-quote) row)))
(defn write-csv
"Given a sequence of sequences of strings, returns a string of that table
@@ -264,13 +264,16 @@ and quotes. The main functions are parse-csv and write-csv."}
:end-of-line - A string containing the end-of-line character
for writing CSV files. Default value: \\n
:quote-char - A character that is used to begin and end a quoted cell.
- Default value: \\\""
- [table & {:keys [delimiter quote-char end-of-line]
- :or {delimiter \, quote-char \" end-of-line "\n"}}]
+ Default value: \\\"
+ :force-quote - Forces every cell to be quoted, required for compatability with Excel
+ Default value: false"
+ [table & {:keys [delimiter quote-char end-of-line force-quote]
+ :or {delimiter \, quote-char \" end-of-line "\n" force-quote false}}]
(loop [csv-string (StringBuilder.)
quoted-table (map #(quote-and-escape-row %
(str delimiter)
- quote-char)
+ quote-char
+ force-quote)
table)]
(if (empty? quoted-table)
(.toString csv-string)
1  target/stale/extract-native.dependencies
View
@@ -0,0 +1 @@
+([:dependencies ([org.clojure/clojure "1.3.0"])])
Something went wrong with that request. Please try again.