chore(multi): Remove use of deprecated lifecycle methods #94
Conversation
- Remove use of deprecated componentWillMount
|
👋 @davidtheclark. I've created this PR to prevent React warnings and errors in the upcoming versions. Please let me know what you think about this approach and if you have any concern or suggestion. |
| @@ -17,7 +17,7 @@ module.exports = class extends React.Component { | |||
| ambManager: PropTypes.object.isRequired | |||
| }; | |||
|
|
|||
| componentWillMount() { | |||
| componentDidMount() { | |||
There was a problem hiding this comment.
Should we use the constructor, instead?
There was a problem hiding this comment.
Up to you. I'm not very familiar with this codebase and I decided to update this based on React's recommendation. ATM this will only be set on the client since this lifecycle method doesn't run on the server.
There was a problem hiding this comment.
I guess we can move this to constructor. @ivoreis any specific reason for it to go inside componentDidMount ?
There was a problem hiding this comment.
This PR goal is to update the code to be compatible with later react version. Can @davidtheclark provide more context why this wasn’t set in the constructor but in componentWillMount instead in the first place?
There was a problem hiding this comment.
@davidtheclark Any update on this ?
There was a problem hiding this comment.
I can't think of any reason.
There was a problem hiding this comment.
@ivoreis Let's move this inside constructor ?
|
@davidtheclark I am planning to merge this PR after verifying all the functionalties. Can create a seperate PR for whatever refactoring needed. Will let you once everything is merged, so we will be needing a release after that |
React will deprecate a few lifecycle methods and
componentWillMountis one of them:https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#gradual-migration-path
Two possible ways to solve this:
componentWillMountwithUNSAFE_componentWillMountcomponentWillMountwithcomponentDidMountThis PR removes use of deprecated
componentWillMountmethod and replaces withcomponentDidMount+constructor