outside bounds access during xml parsing

[pauldreik]

Fuzzing dlib::xml_parser I found a crash after 177 milliseconds. It's a string access outside bounds in this function

I will submit a pull request with the fix (replacing str[i] with str.at(i)).

[pauldreik]

The crashing input was:

 "<?>\0"

but it can probably be minimized more.

[davisking]

Thanks for finding this. Don't replace it with str.at(i) though. That will break the contract for this method, and for the parser as a whole. In this case, you should return -1, as this is what the contract in the header for this method indicates should happen in such situations.

[dlib-issue-bot]

Warning: this issue has been inactive for 35 days and will be automatically closed on 2019-09-10 if there is no further activity.

If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search.

[pauldreik]

I guess I will have to spend more than 30 s on the fix :-)

[dlib-issue-bot]

Warning: this issue has been inactive for 35 days and will be automatically closed on 2019-10-21 if there is no further activity.

If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search.

[dlib-issue-bot]

Warning: this issue has been inactive for 43 days and will be automatically closed on 2019-10-21 if there is no further activity.

If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search.

[dlib-issue-bot]

Notice: this issue has been closed because it has been inactive for 45 days. You may reopen this issue if it has been closed in error.