Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Moose needed as a prerequisite? #14

Closed
robrwo opened this issue Nov 4, 2018 · 4 comments · Fixed by #26
Closed

Is Moose needed as a prerequisite? #14

robrwo opened this issue Nov 4, 2018 · 4 comments · Fixed by #26

Comments

@robrwo
Copy link

robrwo commented Nov 4, 2018

Shouldn't Moose be a test prereq?

@JJ
Copy link
Contributor

JJ commented May 7, 2019

It's already a build prereq. What do you mean?

@robrwo
Copy link
Author

robrwo commented Jun 3, 2019

It's not needed for building or running, only for tests. It should be a recommended test prereq so that the test skips if Moose is not installed.

@davorg
Copy link
Collaborator

davorg commented Jun 3, 2019

Does ExtUtils::MakeMaker have a way to declare recommended test prereqs?

@robrwo
Copy link
Author

robrwo commented Jun 5, 2019

Well, at the minimum Moose could be moved from PREREQ_PM to TEST_REQUIRES.

But you may be able to change the META_MERGE for

  prereqs => {
    "recommends" => {  "Moose" => 0 },
  }

choroba added a commit to choroba/moox-role-json_ld that referenced this issue Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants