Permalink
Commits on Sep 15, 2018
  1. Merge pull request #891 from scop/spelling

    davvid committed Sep 15, 2018
    * scop/spelling:
      Spelling and grammar fixes
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
  2. doc/relnotes: mention the spelling and grammar fixes for v3.3

    davvid committed Sep 15, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  3. widgets: use the default text cursor

    davvid committed Sep 15, 2018
    The block cursor, while being larger and easier to see, has usability
    issues that detracts from the benefits of a larger cursor.
    
    One important issue is that block cursors are traditionally used to
    indicate a difference between "Insert" and "Overwrite" mode.  Cola does
    not have this distinction, and thus using a block cursor conveys the
    wrong message to users.  Furthermore, it can be harder to tell exactly
    where text will be inserted when using a block cursor.
    
    Revert to using the default text cursor.
    
    Closes #889
    Suggested-by: @et304383 via github.com
    Helped-by: Charles <char101@ui.ac.id>
    Helped-by: Ville Skyttä <ville.skytta@iki.fi>
    Signed-off-by: David Aguilar <davvid@gmail.com>
  4. Spelling and grammar fixes

    scop committed Sep 15, 2018
Commits on Sep 2, 2018
  1. Merge pull request #884 from cclauss/patch-2

    davvid committed Sep 2, 2018
    * cclauss/patch-2:
      Makefile: 'make flake8' tests all of contrib and share
    
    Resolves #884
    Signed-off-by: David Aguilar <davvid@gmail.com>
  2. doc: update v3.3 release notes draft

    davvid committed Sep 2, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
Commits on Aug 31, 2018
  1. pynsist-preamble.py: improve code style

    davvid committed Aug 31, 2018
    Suggested-by: @cclauss
    Signed-off-by: David Aguilar <davvid@gmail.com>
  2. README.md: use https:// links where available

    davvid committed Aug 31, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  3. README.md: remove dead link to opensuse

    davvid committed Aug 31, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  4. README.md: replace arch/yaourt with a link to the AUR

    davvid committed Aug 31, 2018
    Closes #883
    Reported-by: Erop @EgZvor
    Helped-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
    Signed-off-by: David Aguilar <davvid@gmail.com>
  5. doc: add Erop to the credits

    davvid committed Aug 31, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  6. Makefile: check contrib/win32 with flake8 only

    davvid committed Aug 31, 2018
    pylint does not take directory names.  It takes module names.
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
  7. Makefile: list sources when running flake8

    davvid committed Aug 31, 2018
    The user might have virtualenvs and/or python installations (via
    contrib/build-git-cola.sh) in their worktree, so invoking flake8 with
    '.' is too wide a net and can be very slow.
    
    We expect virtualenvs and tox environments to exist, per the
    .gitignore rules, but the flake8 invocation would pick them up.
    
    It's also unclear whether the `--exclude` flag replaces, or
    augments the built-in exclusion list.  From the looks of it, the
    flag full-on replaces the built-in patterns, which means that we
    would also need to list `.git`, `__pycache__`, and other
    possible directories in the exclusion list.
    
    Maintaining an exclusion list in a world of virtualenvs is more
    effort than using $(ALL_PYTHON_DIRS) in the target.
    
    In light of this, it's better to be consistent with the rest of
    the Makefile targets.  Use $(ALL_PYTHON_DIRS) and add
    `contrib/win32` to the list of checked python directories so
    that the pynsist preamble is picked up by pylint and flake8.
    
    Related-to: #879
    Reverts: af26369
    Signed-off-by: David Aguilar <davvid@gmail.com>
  8. pynsist-preamble: silence flake8 warnings

    davvid committed Aug 31, 2018
    Closes #882
    Related-to: #879
    Reported-by: @cclauss
    Signed-off-by: David Aguilar <davvid@gmail.com>
  9. Merge pull request #879 from cclauss/patch-1

    davvid committed Aug 31, 2018
    * cclauss/patch-1:
      Fix whitespace in extras/__init__.py to placate flake8
      Fix multiple imports on one line in share/doc/git-cola/conf.py
      $(FLAKE8) $(FLAKE8_FLAGS) --exclude=./qtpy .
      Makefile: 'make flake8' tests the entire codebase
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
  10. doc/relnotes: mention the flake8 changes for v3.3

    davvid committed Aug 31, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  11. CONTRIBUTING.md: add a note about `make precommit`

    davvid committed Aug 31, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  12. Merge pull request #881 from Lin-Buo-Ren/fix-translation

    davvid committed Aug 31, 2018
    * Lin-Buo-Ren/fix-translation:
      po: Fix Chinese(Taiwan) Translation
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
Commits on Aug 30, 2018
  1. po: Fix Chinese(Taiwan) Translation

    Lin-Buo-Ren committed Aug 30, 2018
    "Force" is being used in both FETCH and PUSH operations, avoid translating it to "Force push".
    
    Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
  2. Makefile: 'make flake8' tests the entire codebase

    cclauss committed Aug 30, 2018
    It is safer and just as fast to have flake8 test the entire codebase.
  3. Merge pull request #878 from cclauss/patch-1

    davvid committed Aug 30, 2018
    * cclauss/patch-1:
      import os in pynsist-preamble.py
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
  4. doc: add cclaus to the credits

    davvid committed Aug 30, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  5. doc/relnotes: mention the pynsist preamble script fix

    davvid committed Aug 30, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
Commits on Aug 29, 2018
  1. import os in pynsist-preamble.py

    cclauss committed Aug 29, 2018
    __os__ is used 5 times but is never imported.
  2. doc: start the v3.3 cycle with the logo fixes

    davvid committed Aug 29, 2018
    Signed-off-by: David Aguilar <davvid@gmail.com>
  3. Merge pull request #877 from Lin-Buo-Ren/fix-icon

    davvid committed Aug 29, 2018
    * Lin-Buo-Ren/fix-icon:
      logo: Make logo 512x512px
      logo: Drop unnecessary attributes
      logo: Reformat SVG markup using HTML Tidy
      contrib: Implement HTML Tidy config for SVG formatting/cleanup
      logo: Drop xml:space attribute
    
    Signed-off-by: David Aguilar <davvid@gmail.com>
Commits on Aug 25, 2018
  1. logo: Make logo 512x512px

    Lin-Buo-Ren committed Aug 25, 2018
    * Fix aspect ratio to 1:1
    * Use base-2 side length
    
    Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
  2. logo: Drop unnecessary attributes

    Lin-Buo-Ren committed Aug 25, 2018
    Eliminate attributes that are only local machine relevant, privacy
    leaking and simply not useful for diff-ing.
    
    The tool used to do the job is a personal project "Clean Filter for SVG"
    and is accessible at https://github.com/Lin-Buo-Ren/Clean-Filter-for-SVG
    , the actual code that do the XML processing: [1].  HTML Tidy must be run
    with the contrib/svg.tidy config to restore the current markup style.
    
    [1] https://github.com/Lin-Buo-Ren/Clean-Filter-for-SVG/blob/0ff326b/Clean%20Filter%20for%20SVG.bash#L351-L432
    
    Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
  3. logo: Reformat SVG markup using HTML Tidy

    Lin-Buo-Ren committed Aug 21, 2018
    Using known formatter to allow future modifications.
    
    Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
  4. contrib: Implement HTML Tidy config for SVG formatting/cleanup

    Lin-Buo-Ren committed Aug 21, 2018
    Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
  5. logo: Drop xml:space attribute

    Lin-Buo-Ren committed Aug 21, 2018
    Allow XML formatters to reindent SVG's markup content.
    
    Refer-to: xmllint failed to properly `--format` certain SVG image (#16)
    · Issues · GNOME / libxml2 · GitLab
    <https://gitlab.gnome.org/GNOME/libxml2/issues/16>
    Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>