Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wrong files for 'London St Pancras' on Thameslink Core #80

Closed
313rail opened this issue Dec 20, 2023 · 15 comments
Closed

Using wrong files for 'London St Pancras' on Thameslink Core #80

313rail opened this issue Dec 20, 2023 · 15 comments
Assignees
Labels
bug Something isn't working class-700

Comments

@313rail
Copy link

313rail commented Dec 20, 2023

On the class 700 in real life London St Pancras on the Thameslink core uses the recording 'London St Pancras International' and uses the CRS code 'SPL' instead of what you are using at the moment which is the high level platforms saying just 'london st Pancras' which uses CRS code 'STP'

@davwheat
Copy link
Owner

The GTR and Southeastern CIS's announce St Pancras Low Level/High Speed as "London St Pancras International" in real life.

The EMR CIS announces St Pan High Level as "London St Pancras" in real life.

The system is simply attempting to model different systems as well as possible.

liveTrainsTiplocStationOverrides(tiploc: string): string | null {
switch (tiploc) {
case 'STPX': // STP EMR
return 'STP'
case 'STPXBOX': // STP low level
case 'STPANCI': // STP high speed
return 'STP - St Pancras International'
}

@davwheat davwheat closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
@313rail
Copy link
Author

313rail commented Dec 20, 2023

Fair enough

@GTRspotter
Copy link

Shouldn't there be an option to choose whether you want the GTR 'London St Pancras International' or the EMR 'London St Pancras'.

@davwheat
Copy link
Owner

Quite honestly, that's a big chunk of work to implement with how it's all set up at the moment, with rather little benefit.

@GTRspotter
Copy link

Just wondering, is the GTR 'London St Pancras International' audio file on this website? I would like to use this myself

@313rail
Copy link
Author

313rail commented Dec 31, 2023

Can't you just add another button for it

@GTRspotter
Copy link

He said it's a big chunk of work for little benefit, which is fair enough.

@GTRspotter
Copy link

GTRspotter commented Jan 2, 2024

Does it really take a lot of work to add 1 file? I'm just wondering.

@davwheat
Copy link
Owner

davwheat commented Jan 2, 2024

It's not about adding the file. All the files available are there, and all the files are already used as I mentioned earlier, depending on whether it's High Speed, Midland or Thameslink platforms.

There is no London St Pancras Intl file in the audio, though, to answer your question, hence the use of St Pancras Intl instead.

And I can't just "add another button for it", which is the main issue.

@GTRspotter
Copy link

GTRspotter commented Jan 2, 2024

I found the file for the TL St Pancras Intl. And why are there so many in the screenshot you sent above?

@davwheat
Copy link
Owner

davwheat commented Jan 2, 2024

Because that's how many there are?

@GTRspotter
Copy link

GTRspotter commented Jan 2, 2024

Whats the inflection?

@davwheat
Copy link
Owner

davwheat commented Jan 2, 2024

start/middle/end of a sentence

@GTRspotter
Copy link

oh ok

@313rail
Copy link
Author

313rail commented Jan 2, 2024

I was referring to onboard the 700/707s. The files
Screenshot_20240102-170814
do exist as STA_SPL and STB_SPL

@davwheat davwheat reopened this Apr 16, 2024
@davwheat davwheat self-assigned this Apr 16, 2024
@davwheat davwheat added the bug Something isn't working label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working class-700
Projects
None yet
Development

No branches or pull requests

3 participants