diff --git a/Build.PL b/Build.PL index e0fcfa3..3589825 100644 --- a/Build.PL +++ b/Build.PL @@ -25,6 +25,7 @@ my $build = Module::Build->new( 'LWP::Simple' => 0, 'perl' => 5.006, 'Test::CPAN::Meta::YAML::Version' => '0', + 'ExtUtils::Manifest' => 0, }, build_requires => { 'Test::More' => '0', diff --git a/Changes b/Changes index 71606d6..e8fa706 100644 --- a/Changes +++ b/Changes @@ -9,6 +9,7 @@ - some pod improvements (jquelin) - fix rt#65903 - no more Test::YAML::Meta::Version on CPAN (jquelin) - replace YAML::Syck with YAML::Any (rurban) + - no_symlinks checks only files in MANIFEST, use ExtUtils::Manifest::maniread (rurban) 0.85 2009-07-12, Alexandr Ciornii - fix fails on non-Win32 diff --git a/lib/Module/CPANTS/Kwalitee/Files.pm b/lib/Module/CPANTS/Kwalitee/Files.pm index 357a0f1..7bd47fa 100644 --- a/lib/Module/CPANTS/Kwalitee/Files.pm +++ b/lib/Module/CPANTS/Kwalitee/Files.pm @@ -9,6 +9,7 @@ use Data::Dumper; use Readonly; use Software::LicenseUtils; use File::Slurp qw(slurp); +use ExtUtils::Manifest; sub order { 10 } @@ -60,11 +61,14 @@ sub analyse { $me->d->{size_unpacked}=$size; # find symlinks + my $manifest = -f catfile($distdir, 'MANIFEST') + ? ExtUtils::Manifest::maniread(catfile($distdir, 'MANIFEST')) + : {}; my @symlinks; foreach my $f (@dirs, @files) { - my $p=catfile($distdir,$f); + my $p = catfile($distdir,$f); if (-l $f) { - push(@symlinks,$f); + push(@symlinks,$f) if $manifest and exists $manifest->{$f}; } }