Missing ETF Expense ratio API

[adamcataldo]

Hi,

It doesn't look like this API includes the ETF Expense ratio API:

https://site.financialmodelingprep.com/developer/docs/etf-expense-ratio-api/

I'd be open to contributing this, assuming the process for adding a new endpoint isn't insanely painful.

[ipl31]

Its a V4 endpoint, so you will need to look at another V4 API implementation as an example: https://github.com/daxm/fmpsdk/blob/master/fmpsdk/alternative_data.py I don't know if @daxm has any plans to do an update, I might get around to it in the next few weeks. But it should not be too hard if you are up for it.

[daxm]

I'd love to take on adding v4 API but I'm quite busy.  @ken, if you are up to it I'd encourage you to take it on.  :-)

…

On 10/11/22 22:44, Ken Caruso wrote: Its a V4 endpoint, so you will need to look at another V4 API implementation as an example: https://github.com/daxm/fmpsdk/blob/master/fmpsdk/alternative_data.py I don't know if @daxm <https://github.com/daxm> has any plans to do an update, I might get around to it in the next few weeks. But it should not be too hard if you are up for it. — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZOMZ2K4NOXDVBT6M27UH3WCY625ANCNFSM6AAAAAARC4B5I4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[adamcataldo]

I'm happy to do it, if you're open to pull requests. The code looks straightforward. Two questions:

1. I don't see tests, is that right? I want to make sure I'm not missing a requirements somewhere.
2. What's the release process? I see the deploy_a_release.sh script, but I'm not sure if I can just run that (or if I even should), because I'm not sure what permissions are needed.

[daxm]

I'll do the deploy as it is in my pypi account. I don't know how to do tests (that is why they don't exist). feel free to set that up if you'd like.  :-)  My "tests" are in the example script where I tried to list a "test" for each API call.

…

On 10/12/22 08:59, adamcataldo wrote: I'm happy to do it, if you're open to pull requests. The code looks straightforward. Two questions: 1. I don't see tests, is that right? I want to make sure I'm not missing a requirements somewhere. 2. What's the release process? I see the deploy_a_release.sh <https://github.com/daxm/fmpsdk/blob/master/deploy_a_release.sh> script, but I'm not sure if I can just run that (or if I even should), because I'm not sure what permissions are needed. — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZOMZ6W62RIEZJLHGIQ3GTWC3G4JANCNFSM6AAAAAARC4B5I4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[adamcataldo]

I submitted a pull request. I think setting up the tests is a bigger effort, because you'd probably want to create a fake API that reads a JSON file representing an expected server response and returns that where the FMP server is expected. You'd then you'd need to modularize the functionality in url_methods.py so that tests use the fake service while non-tests use the real service. If you're interested in this, you might be able to persuade me to create the basic setup and a test for say this method, but adding tests for each end-point would probably take quite some time.