Removed the __validate_exchange method since it doesn't allow to manage all supported exchanges #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard-encoded list of exchanges is too narrow.
For example the Italian stock exchange MIL is not included.
I propose to remove the __validate_exchange method completely and let the FMP api themselves manage a non-existing exchange by returning 0 results.
In addition I found a small bug in the
stock_screener
API: parametersis_etf
andis_actively_trading
must be checked forNone
, not forTrue/False
only. Previously, for example, if you specifiedis_etf=False
, it would return both ETFs and stocks.