Skip to content

Commit

Permalink
BoardConfig: fix all the things
Browse files Browse the repository at this point in the history
  • Loading branch information
Daz Jones committed Jan 17, 2013
1 parent b23c1bf commit a66314e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions BoardConfig.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ COMMON_GLOBAL_CFLAGS += -DQCOM_HARDWARE
TARGET_GLOBAL_CFLAGS += -mfpu=neon -mfloat-abi=softfp
TARGET_GLOBAL_CPPFLAGS += -mfpu=neon -mfloat-abi=softfp

WITH_JIT := true

# Optimisations used by Qualcomm
TARGET_CORTEX_CACHE_LINE_32 := true
TARGET_USE_SPARROW_BIONIC_OPTIMIZATION := true
Expand Down Expand Up @@ -56,7 +58,10 @@ BOARD_AVOID_DRAW_TEXTURE_EXTENSION := true
TARGET_GRALLOC_USES_ASHMEM := true

# Web Rendering
ENABLE_JSC_JIT := true
ENABLE_WEBGL := true
HTTP := chrome
JS_ENGINE := v8
TARGET_FORCE_CPU_UPLOAD := true

# USB
Expand Down

4 comments on commit a66314e

@alanorth
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, JIT isn't enabled by default? Wasn't the JIT the big thing that came with Froyo?

@dazjo
Copy link
Owner

@dazjo dazjo commented on a66314e Jan 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these created problems. I fixed them. ;)

@alanorth
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're my hero :)

@LalitMaganti
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can shed a bit more light since I had to play around with these for Skate on 4.1. Essentially the difference as far as I can tell is not made by the JIT defines but the HTTP and JS ones. They are needed otherwise they default to non chrome/v8 and this breaks android as non chrome/v8 is unsupported by android itself since 4.1 I think.

Please sign in to comment.