Skip to content

Commit

Permalink
config.xml: add dualmic back to the comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Daz Jones committed Jun 30, 2013
1 parent aacb3db commit f38e983
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions overlay/frameworks/base/core/res/res/values/config.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
<!-- Set additional audio parameters for incall audio
Usage: parameter=onstring=offstring
Examples: <item>realcall=on=off</item>
<item>dualmic_enabled=true=false</item>
<item>mic_boost=yes=no</item> -->
<string-array name="config_telephony_set_audioparameters" translatable="false">
<item>dualmic_enabled=true=false</item>
Expand Down

3 comments on commit f38e983

@Blefish
Copy link

@Blefish Blefish commented on f38e983 Jul 2, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest implementation like I have? This way the Phone application can toggle it in the settings (in cm-10.1 at least). See https://github.com/Blefish/android_device_huawei_u8800/commit/bc20984dc5dd645741b1d68678a4338f11db4f16

@dazjo
Copy link
Owner

@dazjo dazjo commented on f38e983 Jul 2, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what's the benefit of having this as a setting? The sound is awful without it.

@Blefish
Copy link

@Blefish Blefish commented on f38e983 Jul 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case (U8800), sometimes the dual microphone may not work well or there are cases when it should be disabled so it's always good to have a setting. But if you say there's no point disabling it, keep it your way!

Please sign in to comment.