Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Let DATABASE_URL configure any database. #90

Merged
merged 1 commit into from Apr 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

pwnall commented Apr 15, 2013

This change introduces a parser for the DATABASE_URL environment variable early in the configuration stage, so it can be used to configure any database using any driver.

db-migrate already supports using DATABASE_URL in the Postgres driver. This change makes the support generic.

I hope that you will consider merging it! I'll be happy to address any feedback about the code structure or style.

Thank you very much for db-migrate!

Contributor

pwnall commented Apr 19, 2013

@kunklejr This PR got really big. Please let me know if you'd like me to break it into smaller pieces for your review.

Contributor

kunklejr commented Apr 23, 2013

I've looked through it and it looks good. I just need to find some time to test it and merge.

kunklejr added a commit that referenced this pull request Apr 25, 2013

Merge pull request #90 from pwnall/dburl
Let DATABASE_URL configure any database.

@kunklejr kunklejr merged commit 1e904aa into db-migrate:master Apr 25, 2013

Contributor

pwnall commented Apr 25, 2013

@kunklejr Thank you!!

@pwnall pwnall deleted the pwnall:dburl branch Apr 25, 2013

Contributor

kunklejr commented Apr 25, 2013

No, thank you. I hope to get it into an npm published release this week.

Contributor

kunklejr commented Apr 29, 2013

By the way, I especially wanted to thank you @pwnall for updating the README to match your changes. It really made things easy for me.

Contributor

pwnall commented Apr 29, 2013

@kunklejr You saved my life, it's the least I could do :) Thank you very much for a fully-functioning, well-maintained database migration tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment