From ccf5ed3c2f04c0638e38caa33c92226c15df638e Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Sun, 2 Jul 2023 16:51:09 +0200 Subject: [PATCH 1/3] fix: incorrectly not inheriting values within details elements #494 --- source/_patterns/00-base/_init.scss | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/source/_patterns/00-base/_init.scss b/source/_patterns/00-base/_init.scss index ad72c54c39..0f93665652 100644 --- a/source/_patterns/00-base/_init.scss +++ b/source/_patterns/00-base/_init.scss @@ -1,6 +1,6 @@ // Box sizing html { - box-sizing: border-box; + box-sizing: var(--box-sizing, border-box); } *, @@ -66,3 +66,12 @@ nav, color: $db-color-red-500; } } + +// Incorrect details/summary box-sizing / most likely a browser bug +details[class|="cmp"] { + & > *, + & > ::before, + & > ::after { + box-sizing: var(--box-sizing, border-box); + } +} From 9ac5204b7362acc7addd57cbfd6bf2c96b3443fd Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Sun, 2 Jul 2023 16:54:04 +0200 Subject: [PATCH 2/3] refactor: hardening this --- source/_patterns/00-base/_init.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/_patterns/00-base/_init.scss b/source/_patterns/00-base/_init.scss index 0f93665652..17bd4f3510 100644 --- a/source/_patterns/00-base/_init.scss +++ b/source/_patterns/00-base/_init.scss @@ -1,6 +1,6 @@ // Box sizing html { - box-sizing: var(--box-sizing, border-box); + box-sizing: var(--db-box-sizing, border-box); } *, @@ -68,10 +68,10 @@ nav, } // Incorrect details/summary box-sizing / most likely a browser bug -details[class|="cmp"] { +details { & > *, & > ::before, & > ::after { - box-sizing: var(--box-sizing, border-box); + box-sizing: var(--db-box-sizing, border-box); } } From da89ebb13dc874b0d5eee4eec9e1d769f7a5bafb Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Sun, 2 Jul 2023 17:17:47 +0200 Subject: [PATCH 3/3] docs: further adjusted that comment --- source/_patterns/00-base/_init.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_patterns/00-base/_init.scss b/source/_patterns/00-base/_init.scss index 17bd4f3510..269f2ccf6e 100644 --- a/source/_patterns/00-base/_init.scss +++ b/source/_patterns/00-base/_init.scss @@ -67,7 +67,7 @@ nav, } } -// Incorrect details/summary box-sizing / most likely a browser bug +// details/summary box-sizing / https://kittygiraudel.com/2021/08/23/shadow-roots-and-inheritance/ details { & > *, & > ::before,