From 8c2691a345a400a6e9546827419c16d908e64166 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Thu, 4 Jan 2024 09:28:11 +0100 Subject: [PATCH 1/2] feat: added default:light variant --- source/_patterns/01-elements/chips/chip.scss | 6 ++++++ source/_patterns/01-elements/chips/chips.json | 4 ++++ source/_patterns/01-elements/tags/tag.scss | 6 ++++++ source/_patterns/01-elements/tags/tags.json | 4 ++++ 4 files changed, 20 insertions(+) diff --git a/source/_patterns/01-elements/chips/chip.scss b/source/_patterns/01-elements/chips/chip.scss index 5da587ec46..4c46f47e08 100644 --- a/source/_patterns/01-elements/chips/chip.scss +++ b/source/_patterns/01-elements/chips/chip.scss @@ -42,6 +42,12 @@ color: $chip-checked--color; //*** Variants *** + &[data-variant="light"] { + background-color: $db-color-cool-gray-200; + color: $db-color-cool-gray-700; + border: 1px solid $db-color-cool-gray-400; + } + &[data-variant="warning"] { background-color: $db-color-warning; } diff --git a/source/_patterns/01-elements/chips/chips.json b/source/_patterns/01-elements/chips/chips.json index 1adfeb02ca..348489a50d 100644 --- a/source/_patterns/01-elements/chips/chips.json +++ b/source/_patterns/01-elements/chips/chips.json @@ -1,5 +1,9 @@ { "variants": [ + { + "label": "Light", + "variant": "light" + }, { "label": "Warning", "variant": "warning" diff --git a/source/_patterns/01-elements/tags/tag.scss b/source/_patterns/01-elements/tags/tag.scss index e5541e016f..939ef02f8e 100644 --- a/source/_patterns/01-elements/tags/tag.scss +++ b/source/_patterns/01-elements/tags/tag.scss @@ -27,6 +27,12 @@ } //*** Variants *** + &[data-variant="light"] { + background-color: $db-color-cool-gray-200; + color: $db-color-cool-gray-700; + border: 1px solid $db-color-cool-gray-400; + } + &[data-variant="warning"] { background-color: $db-color-warning-small-font; } diff --git a/source/_patterns/01-elements/tags/tags.json b/source/_patterns/01-elements/tags/tags.json index 2df5522654..d4d83e7be3 100644 --- a/source/_patterns/01-elements/tags/tags.json +++ b/source/_patterns/01-elements/tags/tags.json @@ -1,5 +1,9 @@ { "variants": [ + { + "label": "Light", + "variant": "light" + }, { "label": "Informative", "variant": "informative" From 00f2d752d28ee5392bcfcd4b293cb8452b70a96c Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Thu, 4 Jan 2024 09:28:45 +0100 Subject: [PATCH 2/2] refactor: chips and tags are supposed to get a font-weight of 500 instead of the default 400 --- source/_patterns/01-elements/chips/chip.scss | 1 + source/_patterns/01-elements/tags/tag.scss | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/source/_patterns/01-elements/chips/chip.scss b/source/_patterns/01-elements/chips/chip.scss index 4c46f47e08..362acdfae6 100644 --- a/source/_patterns/01-elements/chips/chip.scss +++ b/source/_patterns/01-elements/chips/chip.scss @@ -6,6 +6,7 @@ border: solid 1px $db-color-cool-gray-400; border-radius: $chip---radius; display: inline-flex; + font-weight: 500; // Link related styles font-size: to-rem($pxValue: 14); diff --git a/source/_patterns/01-elements/tags/tag.scss b/source/_patterns/01-elements/tags/tag.scss index 939ef02f8e..9271b34673 100644 --- a/source/_patterns/01-elements/tags/tag.scss +++ b/source/_patterns/01-elements/tags/tag.scss @@ -6,10 +6,10 @@ border-radius: $tag---radius; color: $tag---color; display: inline-flex; + font-weight: 500; // Link related styles font-size: to-rem($pxValue: 12); - font-weight: initial; height: to-rem($pxValue: 24); justify-content: center; padding-left: to-rem($pxValue: 4);