Skip to content

fix: duplicated rem units #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix: duplicated rem units #929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33a0fe7
fix: duplicated rem units
mfranzke Aug 13, 2024
981880e
Merge branch 'main' into 927-styleaccordioncss-incorrect-duplicated-m…
nmerget Aug 15, 2024
766e5de
Merge branch 'main' into 927-styleaccordioncss-incorrect-duplicated-m…
mfranzke Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions source/_patterns/02-components/accordion/accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "accordion.variables";

.cmp-accordion {
--db-accordion---paddingLeft: #{to-rem($pxValue: $accordion---paddingLeft)};
--db-accordion---paddingLeft: #{$accordion---paddingLeft};
border-bottom: 1px solid $db-color-cool-gray-200;
padding-left: var(--db-accordion---paddingLeft);
padding-right: $accordion---paddingRight;
Expand Down Expand Up @@ -58,9 +58,7 @@
// Emphasis
&%emphasis-High {
// Calculate especially depending on the icons sizes difference
--db-accordion---paddingLeft: #{to-rem(
$pxValue: $accordion---paddingLeft + 8
)};
--db-accordion---paddingLeft: #{$accordion---paddingLeft + 0.5rem};

summary {
font-weight: 700;
Expand All @@ -79,9 +77,7 @@
// Sizes
&%size-Small {
// Calculate dependending on the icons sizes and margins difference
--db-accordion---paddingLeft: #{to-rem(
$pxValue: $accordion---paddingLeft - 12
)};
--db-accordion---paddingLeft: #{$accordion---paddingLeft - 0.75rem};

summary {
font-size: to-rem($pxValue: 14);
Expand All @@ -98,9 +94,7 @@

&%size-Large {
// Calculate especially depending on the icons sizes difference
--db-accordion---paddingLeft: #{to-rem(
$pxValue: $accordion---paddingLeft + 8
)};
--db-accordion---paddingLeft: #{$accordion---paddingLeft + 0.5rem};

summary {
font-size: to-rem($pxValue: 20);
Expand Down