Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diskrepanz zwischen Sketch Design und Frontend Komponente #85

Closed
1 of 4 tasks
LSchroff opened this issue Jul 2, 2024 · 1 comment · Fixed by db-ui/core#895
Closed
1 of 4 tasks

Diskrepanz zwischen Sketch Design und Frontend Komponente #85

LSchroff opened this issue Jul 2, 2024 · 1 comment · Fixed by db-ui/core#895

Comments

@LSchroff
Copy link
Collaborator

LSchroff commented Jul 2, 2024

Which design system content is impacted?

  • Sketch Web Anwendungen
  • Sketch Android & iOS
  • Sketch Illustrative Icons
  • Sketch Funktionale Icons

Which version is impacted?

2.5.2

Reproduction case

Tab Bar unterscheidet sich in Design und Frontend

Expected Behaviour

Angleichung der Komponente

Screenshots

image
image

Add any other context about the problem here.

No response

mfranzke added a commit to db-ui/core that referenced this issue Jul 23, 2024
closes db-ui/design-feedback#85

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
@mfranzke
Copy link
Member

mfranzke added a commit to db-ui/core that referenced this issue Aug 6, 2024
* refactor(tabs): integrate v2 design

closes db-ui/design-feedback#85

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* refactor: corrected styling

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* feat: added icon

* refactor: added small size

* feat: added small items with icons

* refactor: added correct color value

* refactor: button vertical alignment

* refactor: added pressed state

* Update tab-bar.scss

* refactor: simplification

* Update tab-bar.scss

* refactor: added missing parameter

* refactor: add relevant comment

* refactor: simply enabled multi-line content

* style: feedback

* refactor: we don't want to advertise for this one

* style: adaptions out of feedback

* refactor: corrected these declarations

---------

Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
mfranzke added a commit to db-ui/core that referenced this issue Aug 6, 2024
* refactor(tabs): integrate v2 design

closes db-ui/design-feedback#85

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* refactor: corrected styling

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* feat: added icon

* refactor: added small size

* feat: added small items with icons

* refactor: added correct color value

* refactor: button vertical alignment

* refactor: added pressed state

* Update tab-bar.scss

* refactor: simplification

* Update tab-bar.scss

* refactor: added missing parameter

* refactor: add relevant comment

* refactor: simply enabled multi-line content

* style: feedback

* refactor: we don't want to advertise for this one

* style: adaptions out of feedback

* refactor: corrected these declarations

---------

Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
@leape leape closed this as completed by moving to Done in Design Feedback Issues - Status Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants