From 0468dd10152d3af3ad367b9fd5caee837e96067a Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Tue, 2 Sep 2025 22:40:28 +0200 Subject: [PATCH 1/3] Revert "fix(select): Angular tests (#4903)" This reverts commit 683861fbf91380b33281847da3d3f87c06290a58. --- packages/components/src/components/select/select.lite.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/components/src/components/select/select.lite.tsx b/packages/components/src/components/select/select.lite.tsx index c6a2d1387ff6..572831f1a8b4 100644 --- a/packages/components/src/components/select/select.lite.tsx +++ b/packages/components/src/components/select/select.lite.tsx @@ -238,7 +238,10 @@ export default function DBSelect(props: DBSelectProps) { aria-describedby={props.ariaDescribedBy ?? state._descByIds}> {/* Empty option for floating label */} - + From a67d2b7221d24308b664aefd4cd10355fa5871e2 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Tue, 2 Sep 2025 22:45:42 +0200 Subject: [PATCH 2/3] refactor: corrected those snapshots --- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status diff --git a/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status diff --git a/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status diff --git a/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status diff --git a/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status diff --git a/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 65433151f6f4..77610e64288f 100644 --- a/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option [selected] - - option "Valid" + - option + - option "Valid" [selected] - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status \ No newline at end of file + - status From b54f68e55cb6a2e60adb1e66ead9102ba49205f8 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 2 Sep 2025 21:14:18 +0000 Subject: [PATCH 3/3] auto update snapshots (#4905) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- .../DBSelect-should-have-same-aria-snapshot.yaml | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file diff --git a/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file diff --git a/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file diff --git a/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file diff --git a/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file diff --git a/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml index 77610e64288f..65433151f6f4 100644 --- a/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/select/showcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml @@ -97,8 +97,8 @@ - status - text: Label - combobox "Label": - - option - - option "Valid" [selected] + - option [selected] + - option "Valid" - option "Option 2" - text: Valid Valid message - status @@ -181,4 +181,4 @@ - option - option "Disabled" [selected] - option "Option 2" - - status + - status \ No newline at end of file