Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Nov 26, 2025

Proposed changes

All imports in the declaration are only used as types. Use import type. (@typescript-eslint/consistent-type-imports)XO@typescript-eslint/consistent-type-imports

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/chore-corrected-import

All imports in the declaration are only used as types. Use `import type`. (@typescript-eslint/consistent-type-imports)XO@typescript-eslint/consistent-type-imports
@mfranzke mfranzke self-assigned this Nov 26, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Nov 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

⚠️ No Changeset found

Latest commit: ec008cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Nov 26, 2025
@mfranzke mfranzke enabled auto-merge (squash) November 26, 2025 07:18
@mfranzke mfranzke disabled auto-merge November 26, 2025 08:03
@mfranzke mfranzke merged commit 0cd6c2a into main Nov 26, 2025
@mfranzke mfranzke deleted the chore-corrected-import branch November 26, 2025 08:03
@github-project-automation github-project-automation bot moved this from 🎁 Ready for review to ✅ Done in UX Engineering Team Backlog Nov 26, 2025
@mfranzke mfranzke requested a review from Copilot November 26, 2025 08:03
Copilot finished reviewing on behalf of mfranzke November 26, 2025 08:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an XO linting warning by converting a regular import to a type-only import for StorybookConfig in the Angular storybook configuration file. The change ensures that the import statement correctly indicates that StorybookConfig is only used as a type annotation.

Key Changes

  • Modified the import statement in storybooks/angular-storybook/.storybook/main.ts to use a type-only import for StorybookConfig

@@ -1,4 +1,4 @@
import { StorybookConfig } from '@storybook/angular';
import { type StorybookConfig } from '@storybook/angular';
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax import { type StorybookConfig } is inconsistent with all other storybook configuration files in the repository. All other main.ts files in storybooks use import type { StorybookConfig } instead:

  • storybooks/_storybook/.storybook/main.ts: import type { StorybookConfig }
  • storybooks/react-storybook/.storybook/main.ts: import type { StorybookConfig }
  • storybooks/vue-storybook/.storybook/main.ts: import type { StorybookConfig }

Both syntaxes are valid TypeScript, but for consistency with the rest of the storybook files, please use import type { StorybookConfig } instead of import { type StorybookConfig }.

Suggested change
import { type StorybookConfig } from '@storybook/angular';
import type { StorybookConfig } from '@storybook/angular';

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍄🆙improvement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants