New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PC98DosBoxLoader default mount behavior problem #47

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@pengan1987
Contributor

pengan1987 commented Oct 16, 2018

The "drive_type" option change don't have a default behavior, code based on previous versions (includes the doxbox and pc98doxbox example in this repository) won't work because they don't have a "drive_type" option specified. This change will makes the default behavior compatible with previous versions.

@db48x

This comment has been minimized.

Owner

db48x commented Oct 16, 2018

I thought I fixed it by ensuring that if the drive_type isn't specified, we assume that it's "hdd". This would also be a great fix though.

@pengan1987

This comment has been minimized.

Contributor

pengan1987 commented Oct 16, 2018

I thought I fixed it by ensuring that if the drive_type isn't specified, we assume that it's "hdd". This would also be a great fix though.

I see. The DosBoxLoader is fixed but PC98DosBoxLoader is not, let me fix the PC98 one

@db48x

This comment has been minimized.

Owner

db48x commented Oct 16, 2018

Good point. In fact, because there are multiple sources for the drive_type, perhaps your first fix is better :)

@pengan1987

This comment has been minimized.

Contributor

pengan1987 commented Oct 18, 2018

Sure, I'm reverted back to first fix

@pengan1987 pengan1987 changed the title from Fix dosbox default mount behavior problem to Fix PC98DosBoxLoader default mount behavior problem Oct 21, 2018

@pengan1987

This comment has been minimized.

Contributor

pengan1987 commented Oct 22, 2018

I have updated my change to make the PC98DosBoxLoader inherit the mountZip method from DosBoxLoader, so it will be have same behavior to the DosBoxLoader, the mount command will work with DOSBox-X too. and this change is the simplest way to fix the "no drive_type" issue of PC98DosBoxLoader .

@db48x db48x merged commit 1ff6deb into db48x:master Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment