SelectForm Bug Fixes + Improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cancel button now works (was alias for OK)
* OK button now performs validation, only continues where possible.
* Buttons no longer grab focus (except cancel which doesn't matter) thereby disabling interactive search
* Added help button
* Won't get multiple exceptions from the dialog, no longer need to kill gramps or respond to many exception dialogs to recover.
* CTRL+F (or just start typing) interactive search now works in the form selection dialog. It filters out mismatches. Matches are case insensitive and match anywhere in the string.
* Added Reset filter (doubles as an expand tree button)
* Added compact/compress tree button. Called it Pack as I don't know how to not have buttons homogeneous (set_homogeneous,false doesn't work).
* The form title wasn't being used. It now optionally is (it is if it begins with '/').
e.g. title='/path1/subpath1.1/subpath1.1.1/census 1990'
* when the form title isn't used then the dialog puts legacy entries into the same tree roots as in the past but may organise them by country or state below that.
A Denmark census would be in the path 'Census/Denmark'.
It also continues to use the source's name/title as the description (that is the title is ignored as previously).
Filtering by "Denmark" is an easy way to get to them. In the US you can filter by state, or year of the census.
EXAMPLE TITLES
~~~~~~~~~~~~~~
title="/Death/World Wide/Find a Grave (https:{s}{s}www.findagrave.com{s})"
title="/Birth/Australia/Queensland (registry)"
* The size & position of the select dialog is now remembered in "form.ini".
* New "hover expand" checkbox (state saved in "form.ini"), off by default.
Whole branch expanded when clicked.
Left mouse button expands node only, other buttons expand all children as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancel button now works (was alias for OK)
OK button now performs validation, only continues where possible.
Buttons no longer grab focus (except cancel which doesn't matter) thereby disabling interactive search
Added help button
Won't get multiple exceptions from the dialog, no longer need to kill gramps or respond to many exception dialogs to recover.
CTRL+F (or just start typing) interactive search now works in the form selection dialog. It filters out mismatches. Matches are case insensitive and match anywhere in the string.
Added Reset filter (doubles as an expand tree button)
Added compact/compress tree button. Called it Pack as I don't know how to not have buttons homogeneous (set_homogeneous,false doesn't work).
The form title wasn't being used. It now optionally is (it is if it begins with '/').
e.g. title='/path1/subpath1.1/subpath1.1.1/census 1990'
when the form title isn't used then the dialog puts legacy entries into the same tree roots as in the past but may organise them by country or state below that.
A Denmark census would be in the path 'Census/Denmark'.
It also continues to use the source's name/title as the description (that is the title is ignored as previously).
Filtering by "Denmark" is an easy way to get to them. In the US you can filter by state, or year of the census.
EXAMPLE TITLES
The size & position of the select dialog is now remembered in "form.ini".
New "hover expand" checkbox (state saved in "form.ini"), off by default.
{not shown in the pictures}