Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-ircbot should support "topic: GitHubURL" as alias of "github topic: GitHubURL" #50

Open
tantek opened this issue Feb 19, 2020 · 1 comment

Comments

@tantek
Copy link

@tantek tantek commented Feb 19, 2020

The wgmeeting-github-ircbot should support the syntax:

topic: GitHubURL

where GitHubURL is a URL that starts with https://github.com/ ... and ends with a number segment (optional # fragment), just as it currently supports the "github topic: GitHubURL" syntax, because it is easier to remember, and 100% of past uses of "topic: GitHubURL" were clearly intended to do just that, and had to be unnecessarily followed up by a redundant "github topic: GitHubURL" command.

E.g. from the #css IRC log search results:

2017-04-20
#	shane Topic: https://github.com/w3c/fxtf-drafts/issues/73	22:46:43 PDT
#	shane Github Topic: https://github.com/w3c/fxtf-drafts/issues/73	22:46:57 PDT

#	shane Topic: https://github.com/w3c/fxtf-drafts/issues/69	23:05:39 PDT
#	shane Github Topic: https://github.com/w3c/fxtf-drafts/issues/69	23:05:44 PDT

#	shane Topic: https://github.com/w3c/fxtf-drafts/issues/51	23:16:00 PDT
#	shane Github topic: https://github.com/w3c/fxtf-drafts/issues/51	23:16:06 PDT

2017-05-24
#	myles TOPIC: https://github.com/w3c/csswg-drafts/issues/1345	09:54:12 PDT
#	myles Github topic: https://github.com/w3c/csswg-drafts/issues/1345	09:54:25 PDT

Note that this is a very precise request for what to allow, with the text after "Topic: " immediately being an https://github.com/ URL without anything else preceding, and ending with a URL segment that is a number, to avoid errant use of other GitHub URLs.

Given that level of precision, this reflects existing attempted use in the logs 100%, and is sufficiently guarded against false positives, at least from the past ~4 years of history in the logs.

(Originally published at: https://tantek.com/2020/050/b1/)

@dbaron

This comment has been minimized.

Copy link
Owner

@dbaron dbaron commented Feb 19, 2020

This was supported in my initial version of the bot, but it was one of the first things I had to remove when it was used in a live CSS WG meeting, in 8379709.

Fundamentally, I think this is because there are two separate things that need to happen:

  1. setting the boundaries of the sections for each topic (where each should be a post in a comment on github)
  2. saying where each section should go.

There's a tendency to frequently correct the second one. But if the normal way of doing the second one involves also doing the first one, then any corrections to the second (since people will just use the usual command that they're used to) will also lead to a boundary, which will then lead to incorrect results: the single topic split into multiple pieces, where some of those pieces get posted to the wrong github issue or to no github issue at all.

The use of Topic: lines as separators is a convention predating this bot; it goes back to scribe.perl, which many of the groups using this bot also use.

I'd like to do what's in #45 instead of what's here.

Another possibility (instead of or in addition to #45) would be integrating the correct commands for this bot into Zakim's agenda management features, or integrating similar agenda management features into this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.