Skip to content

Make render async #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbartholomae opened this issue Sep 25, 2020 · 2 comments · Fixed by #10
Closed

Make render async #1

dbartholomae opened this issue Sep 25, 2020 · 2 comments · Fixed by #10
Assignees
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@dbartholomae
Copy link
Owner

dbartholomae commented Sep 25, 2020

At the moment, the full rendering process is synchronous. This prevents us from writing components that fetch data asynchronously, e. g. via a web request. Since markdown is only used for one-off rendering without any interactivity, we don't have to worry about loading states. Therefore we can find a simple solution for asynchronous rendering.

Describe the solution you'd like

Make render asynchronous, so that it renders the existing components as before.

Describe alternatives you've considered

React uses hooks and state to manage asynchronous rendering. This seems to be too complicated for this usecase, though.

Additional context

This is preparation for #2

@dbartholomae dbartholomae added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Sep 25, 2020
@dbartholomae dbartholomae self-assigned this Oct 1, 2020
@KwanJunWen
Copy link

Hi, I am interested on this issue, can I try this ?

@dbartholomae
Copy link
Owner Author

Hi! I've already started on this since no one seemed to have noticed the repo, but if you are interested I could wrap up my refactors next week and then next weekend you could take over :)

@dbartholomae dbartholomae changed the title Create renderAsync function Make render async Oct 9, 2020
This was referenced Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants