Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailto: URL handling in ImprintFragment #3

Merged
merged 1 commit into from Sep 1, 2020

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Jul 16, 2020

  1. android.net.MailTo is broken and not necessary at all in this case
    See https://cketti.de/2020/06/22/android-net-mailto-is-broken/
  2. "android.intent.action.SENDTO" is the proper Intent action to send emails
    See https://cketti.de/2016/01/08/sending-email-using-intents/
  3. Querying PackageManager is unnecessary and doing so will require more work with Android 11
    See https://developer.android.com/preview/privacy/package-visibility

1. android.net.MailTo is broken and not necessary at all in this case
   See https://cketti.de/2020/06/22/android-net-mailto-is-broken/
2. "android.intent.action.SENDTO" is the proper Intent action to send emails
   See https://cketti.de/2016/01/08/sending-email-using-intents/
3. Querying PackageManager is unnecessary and doing so will require more work with Android 11
   See https://developer.android.com/preview/privacy/package-visibility
@mrcodeelements mrcodeelements self-assigned this Jul 17, 2020
@mrcodeelements
Copy link
Collaborator

Hi @cketti,
thank you for your contribution. It's awesome! Plus: you are the first community contributor. 🎉😃

As far as I can tell your contribution will be pulled, but it might take some time before we actually do.

I'm looking forward to receive more of those pull requests. Thanks again!

@mrcodeelements mrcodeelements added the good first issue Good for newcomers label Jul 17, 2020
@SuVpmoran SuVpmoran added this to In progress in Issue-Board Aug 13, 2020
@mrcodeelements mrcodeelements changed the base branch from master to develop September 1, 2020 11:23
@mrcodeelements mrcodeelements merged commit fce96e2 into dbbahnhoflive:develop Sep 1, 2020
@SuVpmoran SuVpmoran moved this from In progress to Done in Issue-Board Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Issue-Board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants