Fix mailto: URL handling in ImprintFragment by cketti · Pull Request #3 · dbbahnhoflive/dbbahnhoflive-android

cketti · 2020-07-16T15:02:25Z

android.net.MailTo is broken and not necessary at all in this case
See https://cketti.de/2020/06/22/android-net-mailto-is-broken/
"android.intent.action.SENDTO" is the proper Intent action to send emails
See https://cketti.de/2016/01/08/sending-email-using-intents/
Querying PackageManager is unnecessary and doing so will require more work with Android 11
See https://developer.android.com/preview/privacy/package-visibility

1. android.net.MailTo is broken and not necessary at all in this case See https://cketti.de/2020/06/22/android-net-mailto-is-broken/ 2. "android.intent.action.SENDTO" is the proper Intent action to send emails See https://cketti.de/2016/01/08/sending-email-using-intents/ 3. Querying PackageManager is unnecessary and doing so will require more work with Android 11 See https://developer.android.com/preview/privacy/package-visibility

mrcodeelements · 2020-07-17T05:42:50Z

Hi @cketti,
thank you for your contribution. It's awesome! Plus: you are the first community contributor. 🎉😃

As far as I can tell your contribution will be pulled, but it might take some time before we actually do.

I'm looking forward to receive more of those pull requests. Thanks again!

mrcodeelements self-assigned this Jul 17, 2020

mrcodeelements added the good first issue Good for newcomers label Jul 17, 2020

mrcodeelements changed the base branch from master to develop September 1, 2020 11:23

mrcodeelements merged commit fce96e2 into dbbahnhoflive:develop Sep 1, 2020

Navigation Menu