Expose disabled prop of Input #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this is what the disabled state looks like: |
pbugnion
reviewed
Apr 7, 2019
| @@ -168,6 +168,11 @@ Input.propTypes = { | |||
| */ | |||
| value: PropTypes.string, | |||
|
|
|||
| /** | |||
| * If true, the input is disabled and can't be clicked on. | |||
There was a problem hiding this comment.
We're annoyingly inconsistent on using true and True in the descriptions. E.g. in_navbar on DropdownMenu has Set this to True if the dropdown is inside a navbar. Default: False., but then all disabled props use the text you suggest. As a low-priority task, we could consistently use one or the other (I think I'm somewhat more in favour of True / False since the consumers of the documentation are Python users).
There was a problem hiding this comment.
Good point. I agree that using True / False makes the most sense.
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
disabledprop of theInputcomponent as suggested in #168