Conversation
pbugnion
reviewed
Apr 17, 2019
pbugnion
reviewed
Apr 17, 2019
pbugnion
reviewed
Apr 17, 2019
pbugnion
reviewed
Apr 17, 2019
Contributor
|
On modals, I expect people will spend a ton of time writing annoying little callbacks like: @app.callback(
Output("modal", "is_open"),
[Input("open", "n_clicks"), Input("close", "n_clicks")],
[State("modal", "is_open")],
)
def toggle_modal(n1, n2, is_open):
if n1 or n2:
return not is_open
return is_openCould we potentially provide a function like: dbc.interaction.bind_modal_callbacks(app, 'modal')? (we could imagine similar callbacks in the I don't think that's in scope for this PR, but it might be worth considering. |
Contributor
|
This looks great! Modulo a couple of comments inline, merge whenever! I think modals and spinners will be a great addition. |
* Add option to right align the dropdown menu * Add right-aligment to docs
Collaborator
Author
|
Thanks for reviewing! I think your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of dash 0.41.0 and dash-renderer 0.22.0, dash-renderer is now using React 16, meaning the work that was happening on the dash-v1 branch can be merged.
Changes include:
Modalcomponents + documentation (Add modals #146)Spinnercomponent + documentation (Add spinners #161)DropdownMenu(Right-aligned menu #139)I made a prerelease for testing: