From ba83900e43ca9e00072310a65f239dc4caa21e45 Mon Sep 17 00:00:00 2001 From: Charming Data Date: Fri, 1 Jul 2022 17:52:07 -0400 Subject: [PATCH 1/2] removed jumbotron since it's deprecated --- .../templates/multi-page-apps/responsive-sidebar/sidebar.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py b/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py index 39aeb98da..085fe1b65 100644 --- a/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py +++ b/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py @@ -101,7 +101,7 @@ def render_page_content(pathname): elif pathname == "/page-2": return html.P("Oh cool, this is page 2!") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), From 3a3e52248da7b6bb365933c2fe3dd28a18a8456e Mon Sep 17 00:00:00 2001 From: tcbegley Date: Sat, 2 Jul 2022 08:33:52 +0100 Subject: [PATCH 2/2] Update other examples also --- .../multi-page-apps/collapsible-sidebar-with-icons/app.py | 5 +++-- examples/python/templates/multi-page-apps/navbar.py | 5 +++-- .../responsive-collapsible-sidebar/sidebar.py | 5 +++-- .../templates/multi-page-apps/responsive-sidebar/sidebar.py | 3 ++- .../multi-page-apps/sidebar-with-submenus/sidebar.py | 5 +++-- examples/python/templates/multi-page-apps/simple_sidebar.py | 5 +++-- 6 files changed, 17 insertions(+), 11 deletions(-) diff --git a/examples/python/templates/multi-page-apps/collapsible-sidebar-with-icons/app.py b/examples/python/templates/multi-page-apps/collapsible-sidebar-with-icons/app.py index 171f274d7..5d924d224 100644 --- a/examples/python/templates/multi-page-apps/collapsible-sidebar-with-icons/app.py +++ b/examples/python/templates/multi-page-apps/collapsible-sidebar-with-icons/app.py @@ -80,12 +80,13 @@ def render_page_content(pathname): elif pathname == "/messages": return html.P("Here are all your messages") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", ) diff --git a/examples/python/templates/multi-page-apps/navbar.py b/examples/python/templates/multi-page-apps/navbar.py index 349b6a2eb..03b7c254d 100644 --- a/examples/python/templates/multi-page-apps/navbar.py +++ b/examples/python/templates/multi-page-apps/navbar.py @@ -42,12 +42,13 @@ def render_page_content(pathname): elif pathname == "/page-2": return html.P("Oh cool, this is page 2!") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", ) diff --git a/examples/python/templates/multi-page-apps/responsive-collapsible-sidebar/sidebar.py b/examples/python/templates/multi-page-apps/responsive-collapsible-sidebar/sidebar.py index e693ed24a..06298c932 100644 --- a/examples/python/templates/multi-page-apps/responsive-collapsible-sidebar/sidebar.py +++ b/examples/python/templates/multi-page-apps/responsive-collapsible-sidebar/sidebar.py @@ -114,12 +114,13 @@ def render_page_content(pathname): elif pathname == "/page-2": return html.P("Oh cool, this is page 2!") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", ) diff --git a/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py b/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py index 085fe1b65..3a979433a 100644 --- a/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py +++ b/examples/python/templates/multi-page-apps/responsive-sidebar/sidebar.py @@ -106,7 +106,8 @@ def render_page_content(pathname): html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", ) diff --git a/examples/python/templates/multi-page-apps/sidebar-with-submenus/sidebar.py b/examples/python/templates/multi-page-apps/sidebar-with-submenus/sidebar.py index c3faee8bd..72323aaf5 100644 --- a/examples/python/templates/multi-page-apps/sidebar-with-submenus/sidebar.py +++ b/examples/python/templates/multi-page-apps/sidebar-with-submenus/sidebar.py @@ -145,12 +145,13 @@ def render_page_content(pathname): elif pathname == "/page-2/2": return html.P("No way! This is page 2.2!") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", ) diff --git a/examples/python/templates/multi-page-apps/simple_sidebar.py b/examples/python/templates/multi-page-apps/simple_sidebar.py index 8ca8daf7f..d111ffba1 100644 --- a/examples/python/templates/multi-page-apps/simple_sidebar.py +++ b/examples/python/templates/multi-page-apps/simple_sidebar.py @@ -69,12 +69,13 @@ def render_page_content(pathname): elif pathname == "/page-2": return html.P("Oh cool, this is page 2!") # If the user tries to reach a different page, return a 404 message - return dbc.Jumbotron( + return html.Div( [ html.H1("404: Not found", className="text-danger"), html.Hr(), html.P(f"The pathname {pathname} was not recognised..."), - ] + ], + className="p-3 bg-light rounded-3", )