Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backports.csv only for py2 #24

Merged
merged 1 commit into from Oct 3, 2017
Merged

Conversation

meeuw
Copy link
Collaborator

@meeuw meeuw commented Aug 17, 2017

Description

Fixed by Terje Røsten
https://bugzilla.redhat.com/attachment.cgi?id=1314388&action=diff

The rationale behind not installing backports.csv for Python 3 is that it isn't available for Fedora.

Checklist

  • I've added this contribution to the CHANGELOG.
  • I've added my name to the AUTHORS file (or it's already there).

@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #24 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #24      +/-   ##
========================================
+ Coverage   98.91%   100%   +1.08%     
========================================
  Files          10     10              
  Lines         276    276              
========================================
+ Hits          273    276       +3     
+ Misses          3      0       -3
Impacted Files Coverage Δ
cli_helpers/compat.py 100% <0%> (+11.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad6175...d503d65. Read the comment docs.

@tsroten
Copy link
Member

tsroten commented Oct 2, 2017

@meeuw We'll need to take out the universal = 1 line from setup.cfg. Then, during a release, I'll build separate Python 2 and Python 3 wheels.

@meeuw meeuw force-pushed the meeuw/backports_csv_only_py2 branch 2 times, most recently from 72664fa to 4303dd9 Compare October 3, 2017 06:56
@meeuw meeuw force-pushed the meeuw/backports_csv_only_py2 branch from 4303dd9 to d503d65 Compare October 3, 2017 06:57
@meeuw
Copy link
Collaborator Author

meeuw commented Oct 3, 2017

allright, rebased and removed [bdist_wheel] (I hope that's what you mean)

@tsroten tsroten merged commit f6c4585 into master Oct 3, 2017
@tsroten tsroten deleted the meeuw/backports_csv_only_py2 branch October 3, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants