Adding TRANSFER keyword and fixing smart completion flag. #132
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pensivebrian
approved these changes
Jan 8, 2018
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we set smart completion to off, it has always been turned back on by the background completion refresher thread. This allowed us to select columns from the current table we are targeting.
This PR removes the initial turn off of smart completion and use default value of true.
Another issue was when typing "Alter Schema xxx" The TRANSFER keyword was not populated. Following the current convention which populates all keywords when the last word before the cursor is a identifier, we will populate the transfer keyword too. We can refactor this when we fine tune smart completion, but this should unblock the current customer experience reported here: #114