Skip to content

Updating exception test for json rpc to only validate exception message. #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrMeemus merged 1 commit into from
Jul 5, 2018
Merged

Updating exception test for json rpc to only validate exception message. #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mssqlcli/jsonrpc/tests/test_jsonrpcclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,7 @@ def test_response_stream_closed_exception(self):
self.assertEqual(
str(exception), u'I/O operation on closed file.')

self.assertTrue(test_client.request_thread.isAlive())
self.assertFalse(test_client.response_thread.isAlive())
test_client.shutdown()
self.assertFalse(test_client.request_thread.isAlive())

@unittest.skip("Disabling until scenario is valid")
def test_stream_has_no_response(self):
Expand Down