Skip to content

fix cred scan issue #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barbaravaldez merged 1 commit into from
Sep 17, 2021
Merged

fix cred scan issue #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/installation/windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Set two environment variables:
set http_proxy=domain\username:password@proxy_server:port
set https_proxy=domain\username:password@proxy_server:port
```
If the Password contains special characters like `@,$,!` (e.g. `password:p@ssword`) then replace the special characters by their hex code equivalents with `%` prefix, as exemplified below:
Copy link

@llali llali Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't make the test fail? the password won't be complex enough

Copy link
Contributor Author

@barbaravaldez barbaravaldez Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the credscan log says that it failed in doc\installation\windows.md(42,)

If the Password contains special characters like `@,$,!` (e.g. `password:PLACEHOLDER`) then replace the special characters by their hex code equivalents with `%` prefix, as exemplified below:
* `@`: `%40`
* `$`: `%24`
* `!`: `%21`
Expand Down