Skip to content

Conversation

@jay-knight
Copy link
Contributor

@jay-knight jay-knight commented Jul 22, 2025

Description

I was seeing duration values like Time: 178.236s (2.0 minutes 58 seconds). This change just removes the ".0" off of the "2.0 minutes" by casting hours and minutes to ints.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install).
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@jay-knight
Copy link
Contributor Author

jay-knight commented Jul 22, 2025

Some additional notes on development: Since I have pgcli installed with pipx, running the tests with just pytest seemed to be picking up THAT version of the code instead of the code that I was altering. Running uv run pytest test_main.py fixed that, consider updating the CONTRIBUTING document accordingly. Similarly, for the pre-commit hook to work, I ran:

$ uv pip install pre-commit
Resolved 9 packages in 3ms
Installed 9 packages in 9ms
 + cfgv==3.4.0
 + distlib==0.4.0
 + filelock==3.18.0
 + identify==2.6.12
 + nodeenv==1.9.1
 + platformdirs==4.3.8
 + pre-commit==4.2.0
 + pyyaml==6.0.2
 + virtualenv==20.32.0
$ uv run pre-commit install
pre-commit installed at .git/hooks/pre-commit
$ .git/hooks/pre-commit
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)Skipped

I would also recommend some details about pre-commit and how that can work with uv in the CONTRIBUTING document.

@j-bennet
Copy link
Contributor

@jay-knight If you submit a PR to update the contributing docs, I'll take it!

@j-bennet j-bennet merged commit a74eab8 into dbcli:main Jul 25, 2025
10 of 22 checks passed
@j-bennet
Copy link
Contributor

Thank you for the PR! 🍒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants