List text search configs \dF

[igncampa]

Should close dbcli/pgcli#887 when it's done

adds the command \dF to list text search configurations

[igncampa]

Ok it's done now. Works beautifully. In theory I rebased and then had to force-push. I'm still fairly new to git so I'm always a bit nervous about force-pushing...

[j-bennet]

I get an error on dF+:

irina@/tmp:test> \dF+
local variable 'schema' referenced before assignment

[igncampa]

So much for saying it works beautifully... Lesson learned

[igncampa]

I'm writing tests for these. Should be done again by the end of the day.

[igncampa]

This PR is ready.

Unrelated question: if I see something worth improving/changing, should I open an issue first and then a PR or should I go straight for a PR and explain the rationale there?

[j-bennet]

No need to open the issue just for the sake of it, just do the PR.

[j-bennet]

The unit tests on your branch fail on pep8 checks. How to fix:

pip install -r requirements-dev.txt
pep8radius master --docformatter -i
# git add and commit changes

[igncampa]

Thanks for the heads-up. Done.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@de761c6). Click here to learn what that means.
The diff coverage is 85.1%.

@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage          ?   54.25%           
=========================================
  Files             ?        6           
  Lines             ?     1047           
  Branches          ?        0           
=========================================
  Hits              ?      568           
  Misses            ?      479           
  Partials          ?        0

Impacted Files	Coverage Δ
pgspecial/dbcommands.py	55.65% <85.1%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de761c6...0393ac7. Read the comment docs.

[j-bennet]

Very nice! I ran into one case where things are still breaking:

(pgcli) --- src/pgspecial ‹igncampa-list-text-search-configs› » pgcli test
irina@/tmp:test> \dF+ swed
local variable 'is_special' referenced before assignment

I'm not providing a correct pattern, but we still want to handle this case.

Looks like you aaalmost there!

[igncampa]

I could really use some insight as to why this is happening. I know the issue is raised by pgcli and not pgspecial, but giving pgcli a read I cannot understand how this could be happening. My intuition tells me it has to do with nested generators, but I'm really lost here.

[j-bennet]

@igncampa Yes, it must be a problem with generator logic somewhere. I'll try to take a look as soon as I can.

[j-bennet]

I think dbc543f fixes the problem.

[igncampa]

Yep, you're right. I tested it on multiple environments and it does work wonderfully now. Thanks!

[j-bennet]

Ok, I'm happy with this PR. I'll have a new release out soon.

Thank you!

🍫