From 209f77f761cdb95fd4c720606b22e3e41e20b716 Mon Sep 17 00:00:00 2001 From: Sychev Andrey Date: Wed, 19 Nov 2025 15:11:01 +0100 Subject: [PATCH 1/2] dbeaver/pro#7549 refactor: adjust padding and color for disabled select state to unify view between disabled controls unify icon view as well --- webapp/common-react/@dbeaver/ui-kit/src/Select/Select.css | 1 - .../common-react/@dbeaver/ui-kit/src/Select/SelectField.css | 4 ++++ .../common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx | 2 +- webapp/packages/core-blocks/src/FormControls/Select.css | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/webapp/common-react/@dbeaver/ui-kit/src/Select/Select.css b/webapp/common-react/@dbeaver/ui-kit/src/Select/Select.css index 68ade9a035c..627d97648dd 100644 --- a/webapp/common-react/@dbeaver/ui-kit/src/Select/Select.css +++ b/webapp/common-react/@dbeaver/ui-kit/src/Select/Select.css @@ -28,7 +28,6 @@ &[aria-disabled='true'] { opacity: var(--dbv-kit-control-disabled-opacity); - color: var(--dbv-kit-select-disabled-foreground); background-color: var(--dbv-kit-select-disabled-background); } &:focus-visible { diff --git a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.css b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.css index a2afdbff887..2064e590d23 100644 --- a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.css +++ b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.css @@ -24,4 +24,8 @@ color: var(--tw-color-gray-500); font-size: var(--dbv-kit-select-font-size); } + + .dbv-kit-select[aria-disabled='true'] .dbv-kit-select__arrow-icon { + color: var(--dbv-kit-select-disabled-foreground); + } } diff --git a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx index aeee1544149..66d71709024 100644 --- a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx +++ b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx @@ -161,7 +161,7 @@ export function SelectField>({ {description && {description}} diff --git a/webapp/packages/core-blocks/src/FormControls/Select.css b/webapp/packages/core-blocks/src/FormControls/Select.css index 78a282d9d76..83192d5e273 100644 --- a/webapp/packages/core-blocks/src/FormControls/Select.css +++ b/webapp/packages/core-blocks/src/FormControls/Select.css @@ -40,7 +40,7 @@ .dbv-kit-select { padding-left: 12px; - padding-right: 4px; + padding-right: 6px; } .dbv-kit-select__item { From 7ac9c599bc474984e58ed106a025a30e7b4f0c52 Mon Sep 17 00:00:00 2001 From: Sychev Andrey Date: Wed, 19 Nov 2025 15:35:21 +0100 Subject: [PATCH 2/2] dbeaver/pro#7549 style: fix if clause --- .../common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx index 66d71709024..5f209f49dd3 100644 --- a/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx +++ b/webapp/common-react/@dbeaver/ui-kit/src/Select/SelectField.tsx @@ -126,7 +126,9 @@ export function SelectField>({ getValueByPath(item, itemDisabled, i => ('disabled' in i ? Boolean((i as unknown as SelectItem).disabled) : false)); const [selectedValue, setSelectedValue] = useState(() => { - if (value !== undefined) return value; + if (value !== undefined) { + return value; + } const firstEnabledItem = items.find(item => !isItemDisabled(item)); return firstEnabledItem ? getItemValue(firstEnabledItem) : undefined;