Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install new software: add hints and brief help #3996

Closed
lemon-juice opened this issue Aug 14, 2018 · 8 comments
Closed

Install new software: add hints and brief help #3996

lemon-juice opened this issue Aug 14, 2018 · 8 comments
Milestone

Comments

@lemon-juice
Copy link

I tried installing SSHJ plugin from https://dbeaver.io/update/sshj/latest/ but I can't do it in 5.1.5 (worked in 5.1.4), I receive this error:

An error occurred during the org.eclipse.equinox.internal.p2.engine.phases.CheckTrust phase.
session context was:(profile=DefaultProfile, phase=org.eclipse.equinox.internal.p2.engine.phases.CheckTrust, operand=, action=).
Error reading signed content.
Exception in opening zip file: C:\Program Files\DBeaver\plugins\org.jkiss.bundle.bouncycastle_1.59.0

I start DBeaver as administrator, of course.

@serge-rider
Copy link
Member

Can't reproduce (as well as #3997).
What Windows version do you use? Do you have internet aaccess or you are behind some proxy?
Could you post full error log?

@lemon-juice
Copy link
Author

I use Windows 10 Home Premium 64-bit, OS Build 17134.191. I don't use any proxy. My internet access seems fine, I've tried installing SSHJ 3 times in the last 2 days but I got the same error every time.

Log:

!SESSION 2018-08-14 19:19:35.448 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_77
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64

!ENTRY org.eclipse.equinox.p2.engine 4 4 2018-08-14 19:20:38.520
!MESSAGE An error occurred during the org.eclipse.equinox.internal.p2.engine.phases.CheckTrust phase.
!SUBENTRY 1 org.eclipse.equinox.p2.engine 4 0 2018-08-14 19:20:38.520
!MESSAGE session context was:(profile=DefaultProfile, phase=org.eclipse.equinox.internal.p2.engine.phases.CheckTrust, operand=, action=).
!SUBENTRY 1 org.eclipse.equinox.p2.engine 4 0 2018-08-14 19:20:38.520
!MESSAGE Error reading signed content.
!STACK 0
java.io.IOException: Exception in opening zip file: C:\Program Files\DBeaver\plugins\org.jkiss.bundle.bouncycastle_1.59.0
	at org.eclipse.osgi.framework.util.SecureAction.getZipFile(SecureAction.java:321)
	at org.eclipse.osgi.internal.signedcontent.SignedBundleHook.getSignedContent(SignedBundleHook.java:212)
	at org.eclipse.equinox.internal.p2.engine.phases.CertificateChecker.checkCertificates(CertificateChecker.java:74)
	at org.eclipse.equinox.internal.p2.engine.phases.CertificateChecker.start(CertificateChecker.java:55)
	at org.eclipse.equinox.internal.p2.engine.phases.CheckTrust.completePhase(CheckTrust.java:52)
	at org.eclipse.equinox.internal.p2.engine.Phase.postPerform(Phase.java:252)
	at org.eclipse.equinox.internal.p2.engine.Phase.perform(Phase.java:102)
	at org.eclipse.equinox.internal.p2.engine.PhaseSet.perform(PhaseSet.java:47)
	at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:77)
	at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:45)
	at org.eclipse.equinox.p2.operations.ProvisioningSession.performProvisioningPlan(ProvisioningSession.java:175)
	at org.eclipse.equinox.p2.operations.ProfileModificationJob.runModal(ProfileModificationJob.java:73)
	at org.eclipse.equinox.p2.operations.ProvisioningJob.run(ProvisioningJob.java:187)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:60)
Caused by: java.io.FileNotFoundException: C:\Program Files\DBeaver\plugins\org.jkiss.bundle.bouncycastle_1.59.0 (The system cannot find the file specified)
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(ZipFile.java:219)
	at java.util.zip.ZipFile.<init>(ZipFile.java:149)
	at java.util.zip.ZipFile.<init>(ZipFile.java:163)
	at org.eclipse.osgi.framework.util.SecureAction.getZipFile(SecureAction.java:304)
	... 13 more

@serge-rider
Copy link
Member

Could you t ry to re-install DBeaver? Maybe plugin files were corrupted during download (reinstalling sshj won't help because it is cached and not downloaded on second attempt).

@lemon-juice
Copy link
Author

I uninstalled DBeaver and installed again (without resetting user data) and installation of SSHJ succeeded. Thanks for your help. But perhaps it would be a good idea to make it a bit more user friendly, for example in case of an error offer an option to clear the plugin files without the need to reinstall DBeaver?

@serge-rider
Copy link
Member

Agreed. The problem is that we are using standard Eclipse p2 update framework. Sometimes it fails to download artifacts and it doesn't has any recovery UI. IT is quite uneasy to fix this from DBeaver side..

@lemon-juice
Copy link
Author

Ok, I see. Then may be at least there could be a warning added somewhere in DBeaver's window, maybe in the Install New Software dialog just before the installation process - just a text in a visible space saying that in case of problems a reinstall of DBeaver is recommended. This warning could also say that after DBeaver upgrade we need to reinstall the plug-ins (which also caught me by surprise and I first thought there was a bug). The same text could also appear on plug-in source pages like https://dbeaver.io/update/sshj/latest/.

If we knew about these issues beforehand we wouldn't need to report them here.

@serge-rider serge-rider changed the title Can't install SSHJ - Error reading signed content Install new software: add hints and brief help Aug 25, 2018
@serge-rider serge-rider added this to the 5.2.1 milestone Aug 25, 2018
@serge-rider
Copy link
Member

Yep, this makes sense.

@serge-rider
Copy link
Member

I believe this should be fixed in #4201
Please reopen if problem remains in 5.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants