Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enquoting selected text deletes it instead #6630

Closed
david-cortes opened this issue Aug 27, 2019 · 10 comments

Comments

@david-cortes
Copy link

commented Aug 27, 2019

Steps to reproduce:

  • Open an SQL editor.
  • Write some select statement.
  • Double-click some non-quoted word from the select statement.
  • Press quote character.

Expected behavior: should enclose in quotes the text that was selected.

Actual behavior: replaces the text with empty quotes.
dbeaver_enquote

@david-cortes david-cortes added the bug label Aug 27, 2019

@serge-rider serge-rider added feature request and removed bug labels Aug 29, 2019

@serge-rider

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

It is not a bug, most of text editors behave this way.
But this could be a good feature.

@serge-rider serge-rider added this to the 6.2.3 milestone Aug 29, 2019

@JuanLH

This comment has been minimized.

Copy link

commented Sep 3, 2019

Hi, which branch I have to clone to get that case?

@david-cortes

This comment has been minimized.

Copy link
Author

commented Sep 3, 2019

Hi, which branch I have to clone to get that case?

Happens on the release version, so I guess all of them would have this behavior.

@p91paul

This comment has been minimized.

Copy link

commented Sep 3, 2019

@JuanLH AFAIK, most work is done on the devel branch

@JuanLH

This comment has been minimized.

Copy link

commented Sep 8, 2019

Hi, I'm trying to run the project for finding the bug but I'm facing errors for missing dependencies, I guess.
I did the following:

  • Clone the repo [devel] branch.
  • I added the existing maven project and I searched the git repo downloaded.
  • Updated maven project.

And I have this
Error for dependencies

I don't know why! please help me for trying to solve the bug!
Maybe you have a documentation for first steps into the project

@JuanLH

This comment has been minimized.

Copy link

commented Sep 8, 2019

Ok, I found https://github.com/dbeaver/dbeaver/wiki/Develop-in-Eclipse I fix that error, I was the plugins.
Now I'm trying to run the project!

@JuanLH

This comment has been minimized.

Copy link

commented Sep 8, 2019

I don't have the same behavior in the SQL editor, look:
enquoting dbeaver 2
I cloned the devel branch.

And I don't have options for connections, maybe I have to include some data, right?
connections

@david-cortes

This comment has been minimized.

Copy link
Author

commented Sep 8, 2019

I don't have the same behavior in the SQL editor, look:
enquoting dbeaver 2
I cloned the devel branch.

And I don't have options for connections, maybe I have to include some data, right?
connections

I don't think there's any need to have data. But how are you producing that video? are you pressing quote character key after selecting the text?

@JuanLH

This comment has been minimized.

Copy link

commented Sep 9, 2019

Ok, I was my bad, it's work fine, now I'm looking for the code of SQL Editor.
finding in this project/module | 2019-09-08 22:01:45.075 - > Start org.jkiss.dbeaver.ui.editors.sql [1.0.16.qualifier]
and putting a breakpoint in SQLEditor class constructor when I press F3 or click on the option for open a SQL editor the program stop, ok I continue going forward but when the program invokes this method in Method class the followings elements don't find, look, I see that this part use an RMI.
Debug source not found

Well, I want to keep going forward debugging until I get the code that opens the panel (i think) with the editor to get the events of this editor.

vivekworks added a commit to vivekworks/dbeaver that referenced this issue Sep 10, 2019
dbeaver#6630 Enquoting selected text deletes it instead
Appended the selected text along when a single or double quote character is entered.

@serge-rider serge-rider modified the milestones: 6.2.3, 6.2.1 Sep 11, 2019

serge-rider added a commit that referenced this issue Sep 11, 2019
Merge pull request #6714 from vivekworks/devel
#6630 Enquoting selected text deletes it instead

@serge-rider serge-rider added this to Backlog in DBeaver project via automation Sep 11, 2019

@serge-rider serge-rider moved this from Backlog to Ready for QA in DBeaver project Sep 11, 2019

@uslss uslss self-assigned this Sep 11, 2019

@uslss

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

verified

@uslss uslss closed this Sep 11, 2019

DBeaver project automation moved this from Ready for QA to Done Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.