Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for org.jkiss.utils.BeanUtils #6174

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
2 participants
@Braavos96
Copy link
Contributor

commented Jun 27, 2019

I've analysed your codebase and noticed that org.jkiss.utils.BeanUtils is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.

@serge-rider

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

Unfortunately we can't use powermock because of Java 11 incompatibility.

@Braavos96 Braavos96 force-pushed the Diffblue-benchmarks:add-diffblue-tests branch from 6165b43 to 8e0caac Jul 1, 2019

@Braavos96

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Hi @serge-rider I have removed the powermock and implemented the interfaces :)

@serge-rider

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Thanks!
BTW I believe you should add yourself in the copyright section (on line 4, similarly to line 3)

Add unit tests for org.jkiss.utils.BeanUtils
These tests were written using Diffblue Cover.

@Braavos96 Braavos96 force-pushed the Diffblue-benchmarks:add-diffblue-tests branch from 8e0caac to 257912c Jul 1, 2019

@Braavos96

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Hi @serge-rider thank you. I added myself to the copyright section :)

@serge-rider serge-rider merged commit b85d65c into dbeaver:devel Jul 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.