Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Use Unicode instead of ASCII? #8

Open
drewish opened this Issue · 2 comments

2 participants

andrew morton William Ledoux
andrew morton
Collaborator

I noticed we're forcing the filenames to Unicode and in my code to copy the tags for the worker I'm extracting them as ASCII as well. I checked and it looks like exiv2 supports Unicode (http://www.exiv2.org/doc/exifcomment_8cpp-example.html) but we should test it etc...

William Ledoux

I need the french accents to be supported in paths.
I quickly replaced String::AsciiValue by String::Utf8Value and it works fine for the only command I use (getImageTags) on linux.
Let me know if you plan to work on this and need someone to make tests on linux or windows

andrew morton
Collaborator

Oh that'd be great. You mind opening up a PR? If you could add a test case that'd be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.