Use Unicode instead of ASCII? #8

Closed
drewish opened this Issue Apr 22, 2012 · 4 comments

Projects

None yet

2 participants

@drewish
Collaborator

I noticed we're forcing the filenames to Unicode and in my code to copy the tags for the worker I'm extracting them as ASCII as well. I checked and it looks like exiv2 supports Unicode (http://www.exiv2.org/doc/exifcomment_8cpp-example.html) but we should test it etc...

@williamledoux

I need the french accents to be supported in paths.
I quickly replaced String::AsciiValue by String::Utf8Value and it works fine for the only command I use (getImageTags) on linux.
Let me know if you plan to work on this and need someone to make tests on linux or windows

@drewish
Collaborator

Oh that'd be great. You mind opening up a PR? If you could add a test case that'd be even better.

@drewish
Collaborator

See #30

@drewish
Collaborator

0.5.0 should handle this correctly.

@drewish drewish closed this Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment