New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs to sub wiki #15

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@markhop
Copy link
Contributor

markhop commented Feb 20, 2013

Move DbFit pages to sub-wiki so they all reside under a page called DbFit.

@benilovj

This comment has been minimized.

Copy link
Member

benilovj commented Feb 21, 2013

Mark, thanks for submitting this. I will hopefully get a chance to check this out tomorrow.

One thing I need to have a think about is the "prepare db" script. I've actually pushed the test DB user creation and DbDeploy table creation into the Chef setup of the development vagrant VM box.

@markhop

This comment has been minimized.

Copy link
Contributor

markhop commented Feb 21, 2013

Ok, thanks Jake.

I did take a look at the VM stuff but got stuck at the dropbox part - is that private as it wouldn't let me access it. That's why the script was added to prepare the MySQL database prior to running Maven build. I had to do something similar for the Postgres database but didn't actually create a script so didn't check that in.

I can remove the script from this pull request for now if you want me too and possibly look at doing another one with all necessary scripts so people can develop without t he VM or Chef.

Thanks

@benilovj

This comment has been minimized.

Copy link
Member

benilovj commented Feb 21, 2013

I did take a look at the VM stuff but got stuck at the dropbox part - is that private as it wouldn't let me access it.

Oh, that's bad. My fault for relying on a Dropbox-hosted basebox. I'm going to fix it ASAP: #17.

I can remove the script from this pull request for now.

That'd be good, because in my eyes these are two separate issues.

possibly look at doing another one with all necessary scripts so people can develop without t he VM or Chef

Before you do that, could I convince you to give the VM another shot (as soon as I've fixed it)? I built it with the idea to:

  • Reduce the setup time for a new contributor (I personally hate following fiddly and long setup instructions)
  • Reduce the number of (and time spent investigating) exactly the type of environment-specific problem thats you are seeing in #16

Vagrant mounts the filesystem with the source code inside the VM (as a shared folder) - or in the very least it does under Mac (I'll check on Windows), so you can develop in your host environment and run the tests from inside the VM where you have everything set up.

@benilovj

This comment has been minimized.

Copy link
Member

benilovj commented Feb 25, 2013

I've cherry-picked the commits for moving the pages and the unit test updates. closing.

@benilovj benilovj closed this Feb 25, 2013

@markhop markhop deleted the markhop:move_docs_to_sub_wiki branch Feb 25, 2013

@benilovj benilovj referenced this pull request Jul 3, 2013

Open

Bundle Fitnesse docs #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment